Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R2-solve!-0-allocation #147

Conversation

MohamedLaghdafHABIBOULLAH
Copy link
Contributor

@MohamedLaghdafHABIBOULLAH MohamedLaghdafHABIBOULLAH commented Sep 5, 2024

I addressed issue #146 and added a test file to verify zero allocations in solve!.

Additionally, the ShiftedProximalOperators package needs to be updated to the latest version to ensure the tests pass.

@dpo @MaxenceGollier .

No need to specify the stats within R2 for the moment as we are interested by the allocations of ```solve!```
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.89%. Comparing base (e0f214d) to head (477a490).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/R2_alg.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   61.53%   59.89%   -1.64%     
==========================================
  Files          11       11              
  Lines        1292     1304      +12     
==========================================
- Hits          795      781      -14     
- Misses        497      523      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpo dpo merged commit c37c512 into JuliaSmoothOptimizers:master Sep 9, 2024
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants