Add jth_hess_coord!, jth_hprod! and ghjvprod! #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontoison
force-pushed
the
new_routine
branch
from
6650283 to
10ccc77
Compare
|
You need to add The unit tests are https://github.com/JuliaSmoothOptimizers/NLPModelsTest.jl/blob/main/src/nlp/consistency.jl but excluded by default for these. |
tmigot
requested changes
Aug 19, 2024
amontoison
commented
Aug 19, 2024
|
@tmigot I don't understand the CI error. |
amontoison
force-pushed
the
new_routine
branch
from
8784d14 to
0392b06
Compare
tmigot
requested changes
Aug 19, 2024
amontoison
force-pushed
the
new_routine
branch
from
2d7c5a6 to
996780c
Compare
Co-authored-by: Tangi Migot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tmigot Do we have some unit tests for these routines?