Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep ExaModels.jl and MadNLP.jl for breakage tests #488

Closed
amontoison opened this issue Dec 8, 2024 · 3 comments
Closed

Keep ExaModels.jl and MadNLP.jl for breakage tests #488

amontoison opened this issue Dec 8, 2024 · 3 comments
Assignees

Comments

@amontoison
Copy link
Member

In #483, @tmigot updated the workflow for breakage but removed the packages of our colleagues François and Sungho.
We should keep them because we already broke these packages with a minor release in the past.

@dpo
Copy link
Member

dpo commented Dec 8, 2024

I don't think it's for us to check breakage of outside packages, but for them to properly manage the version they use and report bugs, if any.

@amontoison
Copy link
Member Author

amontoison commented Dec 8, 2024

I agree but we should also not break them with minor releases.
It was totally our fault (release 0.21.2), and we did a quick fix with 0.21.3.

It's just additional tests, which is not bad for us.
It's for the same kind of reason that we run tests on FreeBSD.

@dpo
Copy link
Member

dpo commented Dec 8, 2024

We test on FreeBSD to check that the code runs on FreeBSD, not to verify that we don't break other packages. Our Breakage workflow is already extensive enough. Breakage checks in external packages should happen in PRs to those packages' repos. That's what we do. We should just be careful with minor/major version bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants