From 21c1f41339d2ea664b8206e2ff982dd5b89ad60c Mon Sep 17 00:00:00 2001 From: schillic Date: Fri, 5 Jan 2024 16:59:09 +0100 Subject: [PATCH] mark SDPA tests as broken on v1.10 --- src/algorithms.jl | 3 ++- test/multivariate.jl | 4 ++-- test/runtests.jl | 3 ++- test/univariate.jl | 4 ++-- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/algorithms.jl b/src/algorithms.jl index 405b0a6f..039f2dcc 100644 --- a/src/algorithms.jl +++ b/src/algorithms.jl @@ -126,6 +126,7 @@ Base.@kwdef struct TaylorModelsEnclosure <: AbstractDirectRangeAlgorithm normalize::Bool = true end +# TODO turn example below into doctest when SDPA works again """ SumOfSquaresEnclosure{T} <: AbstractIterativeRangeAlgorithm @@ -147,7 +148,7 @@ result of this algorithm is not rigorous. ### Examples -```jldoctest +```example julia> using SumOfSquares, SDPA, DynamicPolynomials julia> backend = SDPA.Optimizer; diff --git a/test/multivariate.jl b/test/multivariate.jl index 32574cf5..85a26d72 100644 --- a/test/multivariate.jl +++ b/test/multivariate.jl @@ -36,8 +36,8 @@ end # Note: DynamicPolynomials automatically expands p, and evaluation using # interval arithmetic gives a worse left bound than the factored expression. - if Sys.iswindows() - # SDPA is broken on Windows + if Sys.iswindows() || VERSION >= v"1.10" + # SDPA is broken on Windows or v1.10 @test_broken begin x = enclose(p, dom, SumOfSquaresEnclosure(; backend=SDPA.Optimizer)) isapprox(inf(x), 0.0; atol=1e-3) diff --git a/test/runtests.jl b/test/runtests.jl index 5f01ec34..4491cafb 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -1,7 +1,8 @@ using Test, RangeEnclosures using AffineArithmetic, IntervalOptimisation, TaylorModels, SumOfSquares -@static if Sys.iswindows() +@static if Sys.iswindows() || VERSION >= v"1.10" + # SDPA is broken on Windows or v1.10 @test_broken using SDPA else using SDPA diff --git a/test/univariate.jl b/test/univariate.jl index 426a96e6..562670c5 100644 --- a/test/univariate.jl +++ b/test/univariate.jl @@ -50,8 +50,8 @@ end rleft, rright = relative_precision(x, xref) @test rleft ≤ 1e-5 && rright ≤ 1e-5 - if Sys.iswindows() - # SDPA is broken on Windows + if Sys.iswindows() || VERSION >= v"1.10" + # SDPA is broken on Windows or v1.10 @test_broken begin x = enclose(p, dom, SumOfSquaresEnclosure(; backend=SDPA.Optimizer)) xref = interval(4.8333, 10.541)