Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions to Gtk.jl #15

Closed
2 of 3 tasks
tknopp opened this issue Dec 28, 2022 · 8 comments
Closed
2 of 3 tasks

Regressions to Gtk.jl #15

tknopp opened this issue Dec 28, 2022 · 8 comments

Comments

@tknopp
Copy link
Member

tknopp commented Dec 28, 2022

The purpose of this issue is to track regressions compared to Gtk.jl, which will help us to find a good moment for migration of packages.

Mac

  • Windows are popping up in the lower right corner (fixed by GTK4_jll 4.6.9)
  • Windows are opened in the background
  • I have sometimes segfaults when resizing the window (fixed by GTK4_jll 4.6.9)
@jwahlstrand
Copy link
Member

jwahlstrand commented Dec 28, 2022

Windows

  • Fullscreen doesn't work (fixed by GTK4_jll 4.6.9)
  • Pressing buttons inside dialogs doesn't work (seems to be fixed by GTK4_jll 4.6.9)

@jwahlstrand
Copy link
Member

GTK4_jll 4.6.9 is now available. I'm finding that on my Mac, windows are no longer in the lower right corner. They still open behind the Julia terminal but in front of other windows. I haven't seen the segfault issue myself.

@tknopp
Copy link
Member Author

tknopp commented Jan 5, 2023

So the only regression I see is that the Windows on Mac are not opened on top. In my opinion this should not be a show-stopper for the Gtk4 migration. Thought's?

I would like to change Winston.jl very soon to Gtk4, which we can probably use as a first test since it has almost no users. Another idea is then to integrate Gtk4.jl with CairoMakie.jl, see MakieOrg/Makie.jl#568 (comment)

@jwahlstrand
Copy link
Member

jwahlstrand commented Jan 5, 2023

I agree, that's annoying but not terribly so. At some point I will take a shot at updating the JLL to the latest in the 4.8 series. If it's not fixed there we might want to open an issue upstream.

Go for it, if someone wants to use Winston with Gtk.jl they can always pin the Winston version, right?

I have done some work on integrating Gtk4.jl with GLMakie in https://github.com/JuliaGtk/Gtk4Makie.jl. It sort of works on Linux, including interactivity, but my goal is a GLMakie widget and right now you can only have one per window. Attempts to fix this have met resistance so far. It seems like CairoMakie would be easier.

@tknopp
Copy link
Member Author

tknopp commented Jan 5, 2023

I think we want both, CairoMakie and GLMakie integration. How to properly put this into packages is unclear to me. Package extensions will likely change how we structure packages. In this particular case having a "Gtk4" package extension in CairoMakie.jl seems to be a good solution. But this is only theoretical. I have no experience so far.

@tknopp
Copy link
Member Author

tknopp commented Jan 5, 2023

Go for it, if someone wants to use Winston with Gtk.jl they can always pin the Winston version, right?

yep, exactly. I will make a major version bump.

@tknopp
Copy link
Member Author

tknopp commented Jan 5, 2023

Winston migration done: JuliaRegistries/General#75168 :-)

@jwahlstrand
Copy link
Member

ProfileView has been updated to use Gtk4.jl. Seems as good a time as any to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants