From a7596be658bab383f0ddf122bfbd23835ec53fe8 Mon Sep 17 00:00:00 2001 From: Anton Smirnov Date: Tue, 14 Nov 2023 18:55:40 +0200 Subject: [PATCH] Use 1.10 in CI --- .buildkite/pipeline.yml | 24 ++++++++++++++++++++++-- src/device/gcn/hostcall.jl | 4 ++-- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index 75cf738a7..0e3a9a52d 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -22,10 +22,30 @@ steps: if: build.message !~ /\[skip docs\]/ timeout_in_minutes: 10 - - label: "Julia 1.9 - No Artifacts" + # - label: "Julia 1.9 - No Artifacts" + # plugins: + # - JuliaCI/julia#v1: + # version: 1.9 + # - JuliaCI/julia-test#v1: + # - JuliaCI/julia-coverage#v1: + # codecov: true + # agents: + # queue: "juliagpu" + # rocm: "*" + # rocmgpu: "gfx1031" + # if: build.message !~ /\[skip tests\]/ + # command: "julia --project -e 'using Pkg; Pkg.update()'" + # timeout_in_minutes: 180 + # env: + # JULIA_NUM_THREADS: 4 + # JULIA_AMDGPU_CORE_MUST_LOAD: "1" + # JULIA_AMDGPU_HIP_MUST_LOAD: "1" + # JULIA_AMDGPU_DISABLE_ARTIFACTS: "1" + + - label: "Julia 1.10 - No Artifacts" plugins: - JuliaCI/julia#v1: - version: 1.9 + version: 1.10 - JuliaCI/julia-test#v1: - JuliaCI/julia-coverage#v1: codecov: true diff --git a/src/device/gcn/hostcall.jl b/src/device/gcn/hostcall.jl index 9e7a76dd7..29e56fdbe 100644 --- a/src/device/gcn/hostcall.jl +++ b/src/device/gcn/hostcall.jl @@ -131,7 +131,7 @@ function HostCallHolder( try if ret_buf[].ptr != C_NULL && ret_len < sizeof(ret) - Mem.free(ret_buf[]) + # Mem.free(ret_buf[]) ret_len = sizeof(ret) ret_buf[] = Mem.HostBuffer(ret_len, AMDGPU.HIP.hipHostAllocMapped) elseif ret_buf[].ptr == C_NULL @@ -179,7 +179,7 @@ function HostCallHolder( prev == HOST_ERR_SENTINEL || prev == DEVICE_ERR_SENTINEL if not_used - Mem.free(ret_buf[]) # `free` checks for C_NULL. + # Mem.free(ret_buf[]) # `free` checks for C_NULL. buf_ptr = reinterpret(Ptr{Cvoid}, hc.buf_ptr) HIP.hipHostFree(buf_ptr) |> HIP.check break