Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize a few names #135

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Standardize a few names #135

merged 1 commit into from
Mar 11, 2021

Conversation

timholy
Copy link
Member

@timholy timholy commented Mar 10, 2021

"ci" might be a CthulhuInterpreter, CodeInfo, or CallInfo.
Use interp consistently for CthulhuInterpreter.

Also incorporates the test from #134.

@timholy
Copy link
Member Author

timholy commented Mar 10, 2021

(There should be no functional consequences for this change. More significant changes to come.)

"ci" might be a CthulhuInterpreter, CodeInfo, or CallInfo.
Use `interp` consistently for CthulhuInterpreter.

Also incorporates the test from #134.
@codecov-io
Copy link

codecov-io commented Mar 10, 2021

Codecov Report

Merging #135 (65fb0f3) into master (9938126) will increase coverage by 0.22%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   38.53%   38.76%   +0.22%     
==========================================
  Files           7        7              
  Lines         872      872              
==========================================
+ Hits          336      338       +2     
+ Misses        536      534       -2     
Impacted Files Coverage Δ
src/Cthulhu.jl 16.91% <50.00%> (ø)
src/interpreter.jl 94.87% <86.66%> (ø)
src/backedges.jl 80.00% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9938126...65fb0f3. Read the comment docs.

@timholy timholy merged commit f8e680d into master Mar 11, 2021
@timholy timholy deleted the teh/namecleanup branch March 11, 2021 11:29
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 38.76%. Comparing base (9938126) to head (65fb0f3).
Report is 480 commits behind head on master.

Files with missing lines Patch % Lines
src/Cthulhu.jl 50.00% 3 Missing ⚠️
src/interpreter.jl 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   38.53%   38.76%   +0.22%     
==========================================
  Files           7        7              
  Lines         872      872              
==========================================
+ Hits          336      338       +2     
+ Misses        536      534       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants