add documentation for evals_set parameter #387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This isn't an accurate description of this parameter: 7d37634#diff-a4121e6af3eac1a9746b039d2ed91c9682bcfc0422ec37b531a0136d32498e39R82
I think a better name for evals_set would be skip_tuning.
If you're up for it, you can file a PR which removes the evals_set parameter, defaults evals to nothing in the Parameters constructor, and uses tune to update the value of evals only when it is set to nothing, then document the new sentinel value of evals.
|
Thanks for the feedback! I have tried to implement the changes. Closing this PR and starting a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374 adding documentation for the evals_set parameter which seems to be missing otherwise.