Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reversecholesky restrictions #49

Open
ioannisPApapadopoulos opened this issue Nov 8, 2023 · 1 comment
Open

reversecholesky restrictions #49

ioannisPApapadopoulos opened this issue Nov 8, 2023 · 1 comment

Comments

@ioannisPApapadopoulos
Copy link
Member

@dlfivefifty Does the @assert in https://github.com/JuliaApproximation/PiecewiseOrthogonalPolynomials.jl/blob/5c9cc9448b25c62b5b3b5301f12262dca864be29/src/arrowhead.jl#L281C5-L281C5 need to be there?

The matrices for the disk do not fit the exact format for reversecholesky currently implemented in PiecewisePolys and I error at this assert.

@dlfivefifty
Copy link
Member

Did you try deleting it? It'll do the wrong thing probs unless you change the ranges of the for loops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants