Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate and fix rendering of Jupyter artifacts #3877

Open
BilalM04 opened this issue Jul 24, 2024 · 1 comment
Open

De-duplicate and fix rendering of Jupyter artifacts #3877

BilalM04 opened this issue Jul 24, 2024 · 1 comment

Comments

@BilalM04
Copy link
Collaborator

The current Jupyter printer (Language.Drasil.JSON.Print) is heavily duplicated, most of it being a direct copy paste of functions from Language.Drasil.HTML.Print. Duplicated functions should be imported rather than copied.

The Jupyter rendering also uses a lot of Hacky HTML rather than pure markdown, specifically tables. With the new Markdown printer, this hacky HTML should be removed by leveraging the new functions in the Markdown printer and helper. Additionally, several components in the Jupyter artifacts are just broken. For example, list indentation, expressions, and captions.

Goal: Fix broken components and reduce code duplication.

@JacquesCarette
Copy link
Owner

Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants