From 5458241fcd2446412ed493d780a43fc1241947be Mon Sep 17 00:00:00 2001 From: Josh Roy <10731363+JRoy@users.noreply.github.com> Date: Sun, 23 Feb 2025 17:10:05 -0500 Subject: [PATCH] Fix expired mails showing as unread on join (#6063) --- .../java/com/earth2me/essentials/UserData.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/Essentials/src/main/java/com/earth2me/essentials/UserData.java b/Essentials/src/main/java/com/earth2me/essentials/UserData.java index ae71b0cabb1..c5e8fc67ff9 100644 --- a/Essentials/src/main/java/com/earth2me/essentials/UserData.java +++ b/Essentials/src/main/java/com/earth2me/essentials/UserData.java @@ -348,7 +348,17 @@ public void setMails(List mails) { } public int getMailAmount() { - return holder.mail() == null ? 0 : holder.mail().size(); + if (holder.mail() == null) { + return 0; + } + + int amount = 0; + for (MailMessage element : holder.mail()) { + if (!element.isExpired()) { + amount++; + } + } + return amount; } public int getUnreadMailAmount() { @@ -358,7 +368,7 @@ public int getUnreadMailAmount() { int unread = 0; for (MailMessage element : holder.mail()) { - if (!element.isRead()) { + if (!element.isRead() && !element.isExpired()) { unread++; } }