IO ImageBase tests not exercised

[jhlegarreta]

Description

The tests itkLargeImageWriteConvertReadTest and itkLargeImageWriteReadTest are not being exercised as the corresponding itk_add_test command are not present in the relevant CMakeLists.txt file, despite the files being listed:

ITK/Modules/IO/ImageBase/test/CMakeLists.txt

Line 12 in 23da3df

itkLargeImageWriteConvertReadTest.cxx

and

ITK/Modules/IO/ImageBase/test/CMakeLists.txt

Line 13 in 23da3df

itkLargeImageWriteReadTest.cxx

Thus, the corresponding executables are not created.

Steps to Reproduce

1. Get ITK
2. Configure and build
3. Execute

ctest -V -R itkLargeImageWriteConvertReadTest -C Debug

and

ctest -V -R itkLargeImageWriteReadTest-C Debug

CTest will report the message:

No tests were found!!!

Expected behavior

All listed tests should be exercised.

Actual behavior

Tests are not being exercised.

Reproducibility

100%.

Versions

master.

Environment

Any.

Additional Information

None

[dzenanz]

Maybe they were meant to be controlled by ITK_COMPUTER_MEMORY_SIZE, similar to

ITK/Modules/IO/TIFF/test/CMakeLists.txt

Lines 213 to 244 in 76dd332

	if("${ITK_COMPUTER_MEMORY_SIZE}" GREATER 5)
	# Image of 1.67 Gigabytes (pixels size is 16bits)
	itk_add_test(NAME itkLargeTIFFImageWriteReadTest1
	COMMAND ITKIOTIFFTestDriver
	itkLargeTIFFImageWriteReadTest ${ITK_TEST_OUTPUT_DIR}/LargeImage01.tif 30000L)
	# Image of 2.98 Gigabytes (pixels size is 16bits)
	itk_add_test(NAME itkLargeTIFFImageWriteReadTest2
	COMMAND ITKIOTIFFTestDriver
	itkLargeTIFFImageWriteReadTest ${ITK_TEST_OUTPUT_DIR}/LargeImage02.tif 40000L)
	# Image of 4.9 Gigabytes (pixels size is 8-bits out and 16-bit in)
	itk_add_test(NAME itkLargeTIFFImageWriteReadTest3
	COMMAND ITKIOTIFFTestDriver
	itkLargeTIFFImageWriteReadTest ${ITK_TEST_OUTPUT_DIR}/LargeImage03.tif 50000L)
	# Due to the large memory requirements this tests must be run one by one
	set_tests_properties(itkLargeTIFFImageWriteReadTest1
	itkLargeTIFFImageWriteReadTest2
	itkLargeTIFFImageWriteReadTest3
	PROPERTIES
	LABELS BigIO
	RESOURCE_LOCK MEMORY_SIZE
	)
	set_property(TEST itkLargeTIFFImageWriteReadTest1 APPEND PROPERTY LABELS RUNS_LONG)
	set_property(TEST itkLargeTIFFImageWriteReadTest1 APPEND PROPERTY RUN_SERIAL True)
	set_property(TEST itkLargeTIFFImageWriteReadTest2 APPEND PROPERTY LABELS RUNS_LONG)
	set_property(TEST itkLargeTIFFImageWriteReadTest2 APPEND PROPERTY RUN_SERIAL True)
	set_property(TEST itkLargeTIFFImageWriteReadTest3 APPEND PROPERTY LABELS RUNS_LONG)
	set_property(TEST itkLargeTIFFImageWriteReadTest3 APPEND PROPERTY RUN_SERIAL True)
	endif()

[jadh4v]

I can take this up

[jhlegarreta]

@jadh4v Thanks for having addressed this.