Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No upstream is defined for third party /Modules/ThirdParty/libLBFGS #3135

Closed
seanm opened this issue Jan 22, 2022 · 8 comments · Fixed by #5175
Closed

No upstream is defined for third party /Modules/ThirdParty/libLBFGS #3135

seanm opened this issue Jan 22, 2022 · 8 comments · Fixed by #5175
Assignees
Labels
type:Design Improvement in the design of a given area

Comments

@seanm
Copy link
Contributor

seanm commented Jan 22, 2022

There's no Read Me or link to any upstream source repository.

Looks like it might be from here: https://github.com/chokkan/liblbfgs

There are a few warnings in that code that I fixed, and I submitted a patch here: chokkan/liblbfgs#35

But it seems the project may be moribund...

@seanm seanm added the type:Design Improvement in the design of a given area label Jan 22, 2022
@seanm
Copy link
Contributor Author

seanm commented Jan 23, 2025

Just rechecked today's master and ITK/Modules/ThirdParty/libLBFGS still has no Read Me or link to any upstream source repository.

@hjmjohnson hjmjohnson self-assigned this Jan 24, 2025
@hjmjohnson hjmjohnson added this to the ITK 6.0 Beta 1 milestone Jan 24, 2025
@hjmjohnson
Copy link
Member

@dzenanz Could you help build a UpdateFromUpstream for this? I don't know how to do that.

@dzenanz
Copy link
Member

dzenanz commented Jan 24, 2025

@bradking is the expert for this. If he can do it, it would be great. If not, I might get around to it eventually (likely not in time for beta1).

@blowekamp
Copy link
Member

The original commit 7fba333 does not reference the repo, tag or changes made to integrate into ITK. It's not clear to me how hard converting the directory to a sub-tree would be.

@bradking
Copy link
Member

I can look at this, but it would help if someone can find the exact external repository and commit whose content was most recently imported into ITK.

@seanm
Copy link
Contributor Author

seanm commented Jan 24, 2025

I don't know if https://github.com/chokkan/liblbfgs is just some random guy's fork (I suppose we could ask him), or the official upstream, but he did merge my warning fixes a couple of years ago, so that's promising.

@bradking
Copy link
Member

The user name matches the project homepage domain: http://www.chokkan.org/software/liblbfgs/

@bradking
Copy link
Member

#5175 re-imports the same version of libLBFGS that we already have, but with the proper infrastructure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Design Improvement in the design of a given area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants