-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No upstream is defined for third party /Modules/ThirdParty/libLBFGS #3135
Comments
Just rechecked today's master and |
@dzenanz Could you help build a UpdateFromUpstream for this? I don't know how to do that. |
@bradking is the expert for this. If he can do it, it would be great. If not, I might get around to it eventually (likely not in time for beta1). |
The original commit 7fba333 does not reference the repo, tag or changes made to integrate into ITK. It's not clear to me how hard converting the directory to a sub-tree would be. |
I can look at this, but it would help if someone can find the exact external repository and commit whose content was most recently imported into ITK. |
I don't know if https://github.com/chokkan/liblbfgs is just some random guy's fork (I suppose we could ask him), or the official upstream, but he did merge my warning fixes a couple of years ago, so that's promising. |
The user name matches the project homepage domain: http://www.chokkan.org/software/liblbfgs/ |
#5175 re-imports the same version of libLBFGS that we already have, but with the proper infrastructure. |
There's no Read Me or link to any upstream source repository.
Looks like it might be from here: https://github.com/chokkan/liblbfgs
There are a few warnings in that code that I fixed, and I submitted a patch here: chokkan/liblbfgs#35
But it seems the project may be moribund...
The text was updated successfully, but these errors were encountered: