Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Add build compiling with C++20 to GitHub actions. #3097

Closed
phcerdan opened this issue Jan 14, 2022 · 5 comments · Fixed by #5160
Closed

Request: Add build compiling with C++20 to GitHub actions. #3097

phcerdan opened this issue Jan 14, 2022 · 5 comments · Fixed by #5160
Assignees
@devbanu
Labels
Good first issue A good issue for community members new to contributing type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Milestone
ITK 6.0 Beta 1

Comments

@phcerdan
Copy link
Contributor

CDash has builds with C++17 enabled, but they are not triggered when github builds opened PR's.

It would be great to have at least one build (gcc or clang) in github wih C++17.
@phcerdan phcerdan added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label Jan 14, 2022
@dzenanz
Copy link
Member

dzenanz commented Jan 14, 2022 •
edited
Loading

In #2900, a new build was added: LinuxLegacyRemoved. This is being run in our itkrobot.linux Azure account (there are different accounts due to CI execution time limit). A similar thing could be done for MacOS platform, but instead of disabling legacy, enable C++17. Just copy-paste the existing job, modify its name and add C++17 compiler flags where appropriate. The effort will mostly consist of testing, making sure that everything works as intended.

@phcerdan phcerdan added the Good first issue A good issue for community members new to contributing label Jan 14, 2022
@dzenanz
Copy link
Member

dzenanz commented Jan 23, 2025

@devbanu you need to comment here before I can assign this to you.

@devbanu
Copy link

devbanu commented Jan 23, 2025

OK. I am trying to fix this issue.

@devbanu
Copy link

devbanu commented Jan 23, 2025

@dzenanz @phcerdan

Since this issue was created, it seems that the C++17 has been enabled for the whole ITK project in #2563.

But this functionality is still interesting, e.g. for C++20, and so on, so that for a PR one can test with newer standards.

@dzenanz
Copy link
Member

dzenanz commented Jan 23, 2025

Great observation! Can you instead modify one of the builds to use C++20?

@dzenanz dzenanz added this to the ITK 6.0 Beta 1 milestone Jan 23, 2025
@dzenanz dzenanz changed the title Request: Add build compiling with c++17 to github actions. Request: Add build compiling with C++20 to GitHub actions. Jan 23, 2025
@devbanu devbanu mentioned this issue Jan 23, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devbanu devbanu

Labels
Good first issue A good issue for community members new to contributing type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
ITK 6.0 Beta 1
Development

Successfully merging a pull request may close this issue.

ENH: COMP: Adding LinuxCxx20 job to Azure continuous integration. devbanu/ITK
3 participants
@dzenanz @phcerdan @devbanu