From 51a098fd5993df6b5140fd66ebd01ec1e3ace258 Mon Sep 17 00:00:00 2001 From: Hans Johnson Date: Tue, 17 Dec 2024 08:24:23 -0600 Subject: [PATCH] STYLE: Remove compiletime false if statements The test for epsilon > 0 is always true because epsilon is a constexpr greater than 0. --- .../test/itkComposeScaleSkewVersor3DTransformTest.cxx | 5 ----- .../Transform/test/itkScaleSkewVersor3DTransformTest.cxx | 5 ----- .../Core/Transform/test/itkScaleVersor3DTransformTest.cxx | 6 ------ .../Core/Transform/test/itkSimilarity3DTransformTest.cxx | 5 ----- .../Core/Transform/test/itkVersorRigid3DTransformTest.cxx | 5 ----- Modules/Core/Transform/test/itkVersorTransformTest.cxx | 5 ----- 6 files changed, 31 deletions(-) diff --git a/Modules/Core/Transform/test/itkComposeScaleSkewVersor3DTransformTest.cxx b/Modules/Core/Transform/test/itkComposeScaleSkewVersor3DTransformTest.cxx index eb3ac3ac3a7..68a242a79a6 100644 --- a/Modules/Core/Transform/test/itkComposeScaleSkewVersor3DTransformTest.cxx +++ b/Modules/Core/Transform/test/itkComposeScaleSkewVersor3DTransformTest.cxx @@ -86,11 +86,6 @@ itkComposeScaleSkewVersor3DTransformTest(int, char *[]) transform->SetParameters(parameters); - if constexpr (0.0 > epsilon) - { - std::cout << "Error ! " << std::endl; - return EXIT_FAILURE; - } std::cout << " PASSED !" << std::endl; } diff --git a/Modules/Core/Transform/test/itkScaleSkewVersor3DTransformTest.cxx b/Modules/Core/Transform/test/itkScaleSkewVersor3DTransformTest.cxx index 7d22e6c0d69..e310cc965e9 100644 --- a/Modules/Core/Transform/test/itkScaleSkewVersor3DTransformTest.cxx +++ b/Modules/Core/Transform/test/itkScaleSkewVersor3DTransformTest.cxx @@ -89,11 +89,6 @@ itkScaleSkewVersor3DTransformTest(int, char *[]) transform->SetParameters(parameters); - if constexpr (0.0 > epsilon) - { - std::cout << "Error ! " << std::endl; - return EXIT_FAILURE; - } std::cout << " PASSED !" << std::endl; } diff --git a/Modules/Core/Transform/test/itkScaleVersor3DTransformTest.cxx b/Modules/Core/Transform/test/itkScaleVersor3DTransformTest.cxx index d0c553af93c..0b629abbcaf 100644 --- a/Modules/Core/Transform/test/itkScaleVersor3DTransformTest.cxx +++ b/Modules/Core/Transform/test/itkScaleVersor3DTransformTest.cxx @@ -84,12 +84,6 @@ itkScaleVersor3DTransformTest(int, char *[]) transform->SetParameters(parameters); - if constexpr (0.0 > epsilon) - { - std::cout << "Error ! " << std::endl; - return EXIT_FAILURE; - } - transform->Print(std::cout); std::cout << " PASSED !" << std::endl; diff --git a/Modules/Core/Transform/test/itkSimilarity3DTransformTest.cxx b/Modules/Core/Transform/test/itkSimilarity3DTransformTest.cxx index 4c5b0afdc9f..0c3d9b99a1d 100644 --- a/Modules/Core/Transform/test/itkSimilarity3DTransformTest.cxx +++ b/Modules/Core/Transform/test/itkSimilarity3DTransformTest.cxx @@ -93,11 +93,6 @@ itkSimilarity3DTransformTest(int, char *[]) transform->SetParameters(parameters); - if (0.0 > epsilon) - { - std::cout << "Error ! " << std::endl; - return EXIT_FAILURE; - } std::cout << " PASSED !" << std::endl; } { diff --git a/Modules/Core/Transform/test/itkVersorRigid3DTransformTest.cxx b/Modules/Core/Transform/test/itkVersorRigid3DTransformTest.cxx index efc382a4fbe..b0ca65d3a30 100644 --- a/Modules/Core/Transform/test/itkVersorRigid3DTransformTest.cxx +++ b/Modules/Core/Transform/test/itkVersorRigid3DTransformTest.cxx @@ -83,11 +83,6 @@ itkVersorRigid3DTransformTest(int, char *[]) transform->SetParameters(parameters); - if constexpr (0.0 > epsilon) - { - std::cout << "Error ! " << std::endl; - return EXIT_FAILURE; - } std::cout << " PASSED !" << std::endl; } diff --git a/Modules/Core/Transform/test/itkVersorTransformTest.cxx b/Modules/Core/Transform/test/itkVersorTransformTest.cxx index c687023fc1e..14b12354e20 100644 --- a/Modules/Core/Transform/test/itkVersorTransformTest.cxx +++ b/Modules/Core/Transform/test/itkVersorTransformTest.cxx @@ -80,11 +80,6 @@ itkVersorTransformTest(int, char *[]) transform->SetParameters(parameters); - if (0.0 > epsilon) - { - std::cout << "Error ! " << std::endl; - return EXIT_FAILURE; - } std::cout << " PASSED !" << std::endl; }