From 144d19d1551a56da332aecf41d7045ea2b3bc456 Mon Sep 17 00:00:00 2001 From: Hans Johnson Date: Tue, 17 Dec 2024 08:20:47 -0600 Subject: [PATCH] ENH: Remove unconditionally true statement [CTest: warning matched] /Users/builder/externalModules/Filtering/ImageCompare/test/itkSimilarityIndexImageFilterTest.cxx:63:18: warning: result of comparison of 0 <= unsigned expression is always true [-Wtautological-unsigned-zero-compare] 63 | if (lower1 <= count && count <= upper1) | ~~~~~~ ^ ~~~~~ [CTest: warning suppressed] 1 warning generated. --- .../test/itkSimilarityIndexImageFilterTest.cxx | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Modules/Filtering/ImageCompare/test/itkSimilarityIndexImageFilterTest.cxx b/Modules/Filtering/ImageCompare/test/itkSimilarityIndexImageFilterTest.cxx index 494c6b5f752..f64c0bd50ed 100644 --- a/Modules/Filtering/ImageCompare/test/itkSimilarityIndexImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompare/test/itkSimilarityIndexImageFilterTest.cxx @@ -45,11 +45,10 @@ itkSimilarityIndexImageFilterTest(int, char *[]) image1->Allocate(); image2->Allocate(); - const unsigned long numOfPixels = image1->GetBufferedRegion().GetNumberOfPixels(); - constexpr unsigned long lower1 = 0; - const unsigned long upper1 = static_cast(static_cast(numOfPixels) * 0.75) - 1; - const auto lower2 = static_cast(static_cast(numOfPixels) * 0.25); - const unsigned long upper2 = numOfPixels - 1; + const unsigned long numOfPixels = image1->GetBufferedRegion().GetNumberOfPixels(); + const unsigned long upper1 = static_cast(static_cast(numOfPixels) * 0.75) - 1; + const auto lower2 = static_cast(static_cast(numOfPixels) * 0.25); + const unsigned long upper2 = numOfPixels - 1; itk::ImageRegionIterator it1(image1, image1->GetBufferedRegion()); itk::ImageRegionIterator it2(image2, image2->GetBufferedRegion()); @@ -60,7 +59,7 @@ itkSimilarityIndexImageFilterTest(int, char *[]) if (!it1.IsAtEnd()) { - if (lower1 <= count && count <= upper1) + if (count <= upper1) { it1.Set(5); }