From e4a8ae7ba1f6db49fc1d0080b4de02378dd4a5a0 Mon Sep 17 00:00:00 2001 From: Kevin Boulongne Date: Thu, 30 Jan 2025 11:47:56 +0100 Subject: [PATCH] fix: Remove `quickActionBar` blink when opening a Thread --- .../ui/bottomSheetDialogs/UpgradeProductBottomSheetDialog.kt | 2 +- .../java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt | 2 +- app/src/main/res/layout/fragment_thread.xml | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/infomaniak/mail/ui/bottomSheetDialogs/UpgradeProductBottomSheetDialog.kt b/app/src/main/java/com/infomaniak/mail/ui/bottomSheetDialogs/UpgradeProductBottomSheetDialog.kt index a8f14722e1..00c8191bd5 100644 --- a/app/src/main/java/com/infomaniak/mail/ui/bottomSheetDialogs/UpgradeProductBottomSheetDialog.kt +++ b/app/src/main/java/com/infomaniak/mail/ui/bottomSheetDialogs/UpgradeProductBottomSheetDialog.kt @@ -28,7 +28,7 @@ class UpgradeProductBottomSheetDialog : InformationBottomSheetDialog() { super.onViewCreated(view, savedInstanceState) title.setText(R.string.disabledFeatureFlagTitle) - description.text = getString(R.string.disabledFeatureFlagDescription) + description.setText(R.string.disabledFeatureFlagDescription) infoIllustration.setBackgroundResource(R.drawable.ic_update_logo) actionButton.apply { diff --git a/app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt b/app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt index 982461b66a..cdf4abe17e 100644 --- a/app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt +++ b/app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt @@ -481,7 +481,7 @@ class ThreadFragment : Fragment() { iconTint = ColorStateList.valueOf(color) } - binding.quickActionBar.isGone = thread.numberOfScheduledDrafts == thread.messages.size + binding.quickActionBar.isVisible = thread.numberOfScheduledDrafts != thread.messages.size } } diff --git a/app/src/main/res/layout/fragment_thread.xml b/app/src/main/res/layout/fragment_thread.xml index 1e872282a0..17941604b5 100644 --- a/app/src/main/res/layout/fragment_thread.xml +++ b/app/src/main/res/layout/fragment_thread.xml @@ -121,11 +121,13 @@ android:id="@+id/quickActionBar" android:layout_width="match_parent" android:layout_height="wrap_content" + android:visibility="gone" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/threadCoordinatorLayout" - app:menu="@menu/message_menu" /> + app:menu="@menu/message_menu" + tools:visibility="visible" />