Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple pitch accents support #20

Open
ithelor opened this issue Sep 4, 2021 · 2 comments
Open

Multiple pitch accents support #20

ithelor opened this issue Sep 4, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@ithelor
Copy link

ithelor commented Sep 4, 2021

Since many pitch accent dictionaries and databases (Wadoku included) contain multiple pitch accent patterns for some words, it would be useful to have an option to display all of them via this addon. It seems like currently it only generates the first pattern in the column.

Making multiple fields doesn't seem like a working solution due to Anki's limitations, so the optimal one is probably compiling multiple graphs into one SVG vertically. Something similar to how Yomichan resolves multiple pitches (though these are actually separate ones 😐):

imageimageimageimage

@IllDepence
Copy link
Owner

Hi, thanks for the suggestion.

The add-on indeed currently just takes the first pitch pattern listed.
I think supporting multiple patterns would at least require:

  • The possibility so set preferences (currently the add-on has no notion of user preferences stored somewhere)
  • Adaption of the function to manually set a pattern
    • Should it be possible to manually set multiple patterns?
    • Should it be possible to manually edit a single pattern when multiple ones are set?
  • Adaption of the bulk remove functionality
    • If a card has both automatically generated and manually set pitch patterns, what would be the expected behavior of bulk remove? (Feels like an argument for implementing it such that each pattern is in its own svg tag, such that they can be handled individually)

Unfortunately I don't see myself finding the time to address all this in the near future. But I'll keep the notes here just in case.

@IllDepence IllDepence added the enhancement New feature or request label Sep 4, 2021
@Nayelianne
Copy link

+1 for the ability of manually adding multiple pitches in the same field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants