From 2a37c56c311af59b470f1895c5cf5c4a786d8f92 Mon Sep 17 00:00:00 2001 From: Frank Niessink Date: Tue, 28 Jan 2025 20:04:06 +0100 Subject: [PATCH] Fix accessibility issues found by the application test. Fixes #6354. --- components/frontend/public/index.html | 43 +++++++--------------- components/frontend/src/AppUI.js | 2 - components/frontend/src/PageContent.js | 3 ++ docs/src/changelog.md | 4 ++ tests/application_tests/src/test_report.py | 3 +- 5 files changed, 21 insertions(+), 34 deletions(-) diff --git a/components/frontend/public/index.html b/components/frontend/public/index.html index a6bc81c59d..374b72ac05 100644 --- a/components/frontend/public/index.html +++ b/components/frontend/public/index.html @@ -1,16 +1,12 @@ - + - - - - - - - - - Quality-time - - - -
- - + Quality-time + + + + diff --git a/components/frontend/src/AppUI.js b/components/frontend/src/AppUI.js index 4fad490f6e..f8a91d5ff2 100644 --- a/components/frontend/src/AppUI.js +++ b/components/frontend/src/AppUI.js @@ -6,7 +6,6 @@ import { LocalizationProvider } from "@mui/x-date-pickers" import { AdapterDayjs } from "@mui/x-date-pickers/AdapterDayjs" import { bool, func, number, object, string } from "prop-types" import HashLinkObserver from "react-hash-link" -import { ToastContainer } from "react-toastify" import { useSettings } from "./app_ui_settings" import { DataModel } from "./context/DataModel" @@ -87,7 +86,6 @@ export function AppUI({ setUIMode={setMode} uiMode={mode} /> - + {content} ) diff --git a/docs/src/changelog.md b/docs/src/changelog.md index 49c99f3438..4493b434c9 100644 --- a/docs/src/changelog.md +++ b/docs/src/changelog.md @@ -14,6 +14,10 @@ If your currently installed *Quality-time* version is not the latest version, pl ## [Unreleased] +### Fixed + +- Fix accessibility issues found by the application test. Fixes [#6354](https://github.com/ICTU/quality-time/issues/6354). + ### Changed - Use the font configured in the browser instead of the browser's system font. Fixes [#9864](https://github.com/ICTU/quality-time/issues/9864). diff --git a/tests/application_tests/src/test_report.py b/tests/application_tests/src/test_report.py index f39aeaba57..d755663cd0 100644 --- a/tests/application_tests/src/test_report.py +++ b/tests/application_tests/src/test_report.py @@ -126,6 +126,5 @@ def test_report_axe_accessibility(self): self.fail("Could not write axe violations report") # If there are more violations than expected, output the human readable report - # Fixing the axe violations is on the backlog: https://github.com/ICTU/quality-time/issues/6354 - current_number_of_axe_violations = 7 + current_number_of_axe_violations = 0 self.assertLessEqual(len(violation_results), current_number_of_axe_violations, human_readable_axe_report)