pi_user_tags*: all Power Resources are making changes in place when upgrading

[surajsbharadwaj]

Hello Team,

Upgrading from version v1.71.3 to v1.72.2 causes the resources to be modified in place.

Problem seen in v1.72.2

Not sure, why pi_user_tags is getting modified ....

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place
 <= read (data resources)

Terraform will perform the following actions:

  # module.powervs_workspace.ibm_pi_image.import_images["RHEL9-SP2-SAP"] will be updated in-place
  ~ resource "ibm_pi_image" "import_images" {
        id                     = "d0d7628c-26fa-4d15-84c2-5f89f72755aa/cc2d7b89-283e-484e-b5ea-0ad40d6ddfd4"
      + pi_user_tags           = (known after apply)
        # (5 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.powervs_workspace.ibm_pi_image.import_images["SLES15-SP5-SAP"] will be updated in-place
  ~ resource "ibm_pi_image" "import_images" {
        id                     = "d0d7628c-26fa-4d15-84c2-5f89f72755aa/ba389ee9-14ba-4bda-97dd-115173643a04"
      + pi_user_tags           = (known after apply)
        # (5 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.powervs_workspace.ibm_pi_network.private_subnet_1[0] will be updated in-place
  ~ resource "ibm_pi_network" "private_subnet_1" {
        id                          = "d0d7628c-26fa-4d15-84c2-5f89f72755aa/6c5f64bf-80d8-4d16-924b-f4c7687f7589"
      + pi_user_tags                = (known after apply)
        # (13 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.powervs_workspace.ibm_pi_network.private_subnet_2[0] will be updated in-place
  ~ resource "ibm_pi_network" "private_subnet_2" {
        id                          = "d0d7628c-26fa-4d15-84c2-5f89f72755aa/4cb894e6-93e3-4ee9-bc0b-08c2918a7ecc"
      + pi_user_tags                = (known after apply)
        # (13 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.powervs_instance.module.pi_instance.data.ibm_pi_instance.instance_ips_ds will be read during apply
  # (depends on a resource or a module with changes pending)
 <= data "ibm_pi_instance" "instance_ips_ds" {
      + crn                         = (known after apply)
      + deployment_type             = (known after apply)
      + fault                       = (known after apply)
      + health_status               = (known after apply)
      + ibmi_css                    = (known after apply)
      + ibmi_pha                    = (known after apply)
      + ibmi_rds                    = (known after apply)
      + ibmi_rds_users              = (known after apply)
      + id                          = (known after apply)
      + license_repository_capacity = (known after apply)
      + max_virtual_cores           = (known after apply)
      + maxmem                      = (known after apply)
      + maxproc                     = (known after apply)
      + memory                      = (known after apply)
      + min_virtual_cores           = (known after apply)
      + minmem                      = (known after apply)
      + minproc                     = (known after apply)
      + networks                    = (known after apply)
      + pi_cloud_instance_id        = "d0d7628c-26fa-4d15-84c2-5f89f72755aa"
      + pi_instance_name            = "ins-pi"
      + pin_policy                  = (known after apply)
      + placement_group_id          = (known after apply)
      + processors                  = (known after apply)
      + proctype                    = (known after apply)
      + server_name                 = (known after apply)
      + shared_processor_pool       = (known after apply)
      + shared_processor_pool_id    = (known after apply)
      + status                      = (known after apply)
      + storage_connection          = (known after apply)
      + storage_pool                = (known after apply)
      + storage_pool_affinity       = (known after apply)
      + storage_type                = (known after apply)
      + user_tags                   = (known after apply)
      + virtual_cores_assigned      = (known after apply)
      + volumes                     = (known after apply)
    }

  # module.powervs_instance.module.pi_instance.data.ibm_pi_instance_ip.instance_primary_ip_ds will be read during apply
  # (depends on a resource or a module with changes pending)
 <= data "ibm_pi_instance_ip" "instance_primary_ip_ds" {
      + external_ip          = (known after apply)
      + id                   = (known after apply)
      + ip                   = (known after apply)
      + ipoctet              = (known after apply)
      + macaddress           = (known after apply)
      + network_id           = (known after apply)
      + pi_cloud_instance_id = "d0d7628c-26fa-4d15-84c2-5f89f72755aa"
      + pi_instance_name     = "ins-pi"
      + pi_network_name      = "sub_1"
      + type                 = (known after apply)
    }

  # module.powervs_instance.module.pi_instance.ibm_pi_instance.instance will be updated in-place
  ~ resource "ibm_pi_instance" "instance" {
        id                             = "d0d7628c-26fa-4d15-84c2-5f89f72755aa/34ee5078-9471-429f-b887-369b2b580c54"
      + pi_user_tags                   = (known after apply)
        # (36 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

  # module.powervs_instance.module.pi_instance.ibm_pi_volume.create_volume[0] will be updated in-place
  ~ resource "ibm_pi_volume" "create_volume" {
        id                     = "d0d7628c-26fa-4d15-84c2-5f89f72755aa/8b711d7c-0070-4a19-9390-86c7fd5f10f6"
      + pi_user_tags           = (known after apply)
        # (21 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.powervs_instance.module.pi_instance.ibm_pi_volume.create_volume[1] will be updated in-place
  ~ resource "ibm_pi_volume" "create_volume" {
        id                     = "d0d7628c-26fa-4d15-84c2-5f89f72755aa/6e1954cc-5b91-485b-9d91-227d0e9f1db9"
      + pi_user_tags           = (known after apply)
        # (21 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.powervs_instance.module.pi_instance.ibm_pi_volume.create_volume[2] will be updated in-place
  ~ resource "ibm_pi_volume" "create_volume" {
        id                     = "d0d7628c-26fa-4d15-84c2-5f89f72755aa/3ada1fe7-7ba3-44f5-9e2a-4ac6053dd14f"
      + pi_user_tags           = (known after apply)
        # (21 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.powervs_instance.module.pi_instance.ibm_pi_volume.create_volume[3] will be updated in-place
  ~ resource "ibm_pi_volume" "create_volume" {
        id                     = "d0d7628c-26fa-4d15-84c2-5f89f72755aa/3cfaccd0-b7a2-4083-8688-e8ff7406c2ef"
      + pi_user_tags           = (known after apply)
        # (21 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.powervs_instance.module.pi_instance.ibm_pi_volume.create_volume[4] will be updated in-place
  ~ resource "ibm_pi_volume" "create_volume" {
        id                     = "d0d7628c-26fa-4d15-84c2-5f89f72755aa/42099063-5167-4a79-ad3f-658b812d41ea"
      + pi_user_tags           = (known after apply)
        # (21 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 10 to change, 0 to destroy.

Changes to Outputs:
  ~ pi_instance_primary_ip   = "10.51.0.138" -> (known after apply)
  ~ pi_instance_private_ips  = "10.51.0.138, 10.53.0.168" -> (known after apply)

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

terraform.tfstate.txt

[surajsbharadwaj]

pi_user_tags : The value is being changed from null to [] empty list...
v1.71.3 had null
v1.72.2 has []

[Alexander-Kita]

This is working as expected. User tags will now be read as [] when resource has none.