Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise apps filters #378

Open
3 tasks done
sconim opened this issue Dec 17, 2024 · 8 comments
Open
3 tasks done

Revise apps filters #378

sconim opened this issue Dec 17, 2024 · 8 comments
Assignees
Labels
feature request This feature should be implemented

Comments

@sconim
Copy link

sconim commented Dec 17, 2024

Confirmation

Feature Description

Under Apps > Filters, on one hand, some of current filters, such as "apk", or "combine flags" are not very helpful. On the other hand, important filters are missing altogether.

Describe the Solution

Remove useless filters and add other, important important ones.

Describe Alternatives

Add the following apps filters:

  • Disabled (frozen)
  • Stopped (deep sleep)
  • Large heap
  • Launchable
  • Number of trackers
  • Last used

I'm aware the app has a dedicated "Disabled" section however, if the suggested filters are being added, probably this section would no longer be needed?

Moreover, It seems you're already identifying the apps based on their status, however, there is no filter, nor a legend to clarify what the small symbols on the right-hand side represents (see attached screenshot).
Screenshot_20241217_102959_Inure

Additional Context

No response

Sufficiency Confirmation

  • I have provided all the information requested above and deemed sufficient for the developer to address the issue
@sconim sconim added the feature request This feature should be implemented label Dec 17, 2024
@sconim sconim changed the title [Feature Request] Your Title Here [Feature Request] Revise apps filters Dec 17, 2024
@sconim sconim changed the title [Feature Request] Revise apps filters Revise apps filters Dec 17, 2024
@Hamza417
Copy link
Owner

Stopped (deep sleep)
Large heap
Launchable

I'll be adding these three, the first one is already present, so I am not sure why you included that in the list.

The number of trackers requires scanning the complete app components, which isn't feasible since Android has limits on how much data it can transfer through the binder in the system. That's why number of trackers was added in the App Info screen and not the main lists.

Last Used is very much possible, but I will not be adding it into the main list since this filter means an order changing list, I'll either create a dedicated panel for this which sounds plausible use for something like this or add this filter or info in usage stats panel since the data is already available there and won't have much impact on the app performance. The reason I mentioned performance is Usage Stats query often takes more than 3–4 seconds on average devices.

As for Combine Flags, I have been wanting to remove it for a long time, it's done now. I'll think of a better solution to this one.

@Hamza417 Hamza417 added the wip currently being worked upon and expected to be available soon. label Dec 19, 2024
Hamza417 added a commit that referenced this issue Dec 19, 2024
  - Launchable
  - Large Heap
  - Stopped
Hamza417 added a commit that referenced this issue Dec 19, 2024
@Hamza417
Copy link
Owner

Hamza417 commented Dec 19, 2024

I'm aware the app has a dedicated "Disabled" section however, if the suggested filters are being added, probably this section would no longer be needed?

I missed this, yes what you said makes sense, but a dedicated section is useful in a lot of situations even to me as well and many other users, if you don't want it there is an option to hide it completely from the Home screen menu.

Moreover, It seems you're already identifying the apps based on their status, however, there is no filter, nor a legend to clarify what the small symbols on the right-hand side represents (see attached screenshot).

It's symbol for FOSS, Bloat and Tracker, two of them is already shown in the Home screen.

@Hamza417 Hamza417 removed the wip currently being worked upon and expected to be available soon. label Dec 19, 2024
@Hamza417
Copy link
Owner

I have completed the implementations of those which are mentioned in the issue, you can run it and let me know what could be improved or changed.

app-github-release.zip

@sconim
Copy link
Author

sconim commented Dec 19, 2024

The number of trackers requires scanning the complete app components, which isn't feasible since Android has limits on how much data it can transfer through the binder in the system. That's why number of trackers was added in the App Info screen and not the main lists.>

Then add it as a sorting criteria. The App Manager can sort the apps based on the number of trackers without any problems.

I'm having a hard time finding the number of trackers in the App info screen. Where exactly? Could you please be more specific?

@sconim
Copy link
Author

sconim commented Dec 19, 2024

... let me know what could be improved or changed.

app-github-release.zip

The Analytics screen is a poorly utilized gold mine. On the pie charts, when tapped on each individual pie, could you link a new screen showing the filtered apps, instead of just showing the number of apps (which doesn't really provide any info)?

@Hamza417
Copy link
Owner

The Analytics screen is a poorly utilized gold mine. On the pie charts, when tapped on each individual pie, could you link a new screen showing the filtered apps, instead of just showing the number of apps?

It already has a screen for that, you need to tap the popup or long press the legend to get to that.
And, could you please open separate issues for each problem? Or into a dedicated discussion topic for that?

I'm having a hard time finding the number of trackers in the App info screen. Where exactly? Could you please be more specific?

It's in the info strip, the one line below the app package name at the top.

Then add it as a sorting criteria. The App Manager can sort the apps based on the number of trackers without any problems.

I already did a year ago, it was crashing in some devices and increased the loading times significantly which exceeded my less than a second loading time criteria. There is an X Trackers in the App Info section. You can also enable Trackers tag to have tracker indicator shown next to any app with trackers in the whole app, and long pressing menu also provides an option to directly go to trackers screen. If you are more interested in scanning multiple apps at once instead of going one by one, there is also a dedicated Tracker scanner and blocker in the Batch.

I have added the required sort flags and in my test they are working correctly as needed. I am closing the issue now.

@Hamza417 Hamza417 reopened this Dec 28, 2024
Hamza417 added a commit that referenced this issue Dec 28, 2024
- Added as a replacement for combine flags
Hamza417 added a commit that referenced this issue Dec 28, 2024
- Added as a replacement for combine flags
@Hamza417
Copy link
Owner

Screenshot_20241228_105920

Added AND/OR logic in filter a replacement for Combine Flags option, this should add more flexibility and will be distinguishable enough for everyone as well.

@Hamza417
Copy link
Owner

I have also put enough thoughts into the Sort by Number of Trackers criteria, I think with the right approach and methods it's doable fast enough to not break the app flow.

@Hamza417 Hamza417 added the wip currently being worked upon and expected to be available soon. label Dec 28, 2024
@Hamza417 Hamza417 removed the wip currently being worked upon and expected to be available soon. label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request This feature should be implemented
Projects
None yet
Development

No branches or pull requests

2 participants