Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenChecklist - cannot tick the last checklist item #57

Open
psysoo opened this issue Feb 29, 2024 · 7 comments
Open

OpenChecklist - cannot tick the last checklist item #57

psysoo opened this issue Feb 29, 2024 · 7 comments

Comments

@psysoo
Copy link

psysoo commented Feb 29, 2024

OpenChecklist - cannot tick the last checklist item

Screen.Recording.2024-02-29.at.12.14.46.pm-1.mov
@amraboelela
Copy link
Contributor

@amraboelela
Copy link
Contributor

This task will be done only when favourited_properties_count is 3 or more, maybe i shouldn't make it clickable?
{
"name": "Check User Favourites Count",
"action": "checkTag",
"action_data": {
"key": "favourited_properties_count",
"value": "3",
"type": "int",
"operator": "gte" # greater than or equals
}
}

@djinoz
Copy link
Member

djinoz commented Mar 3, 2024

I agree Amr, we need a test case to cause the tag to happen, how did you test it and how can QA test?

@psysoo
Copy link
Author

psysoo commented Mar 4, 2024

@amraboelela I just copied sample yml file and pasted it. then click the 4th item when guide is shown up.

I was trying to test to set the tag and value 3 by the first checklist item. BUT it's blocked by the following bug; somehow shows 8 more tasks instead of showing the items in extra_json.

Screenshot 2024-03-04 at 4 38 51 pm

@amraboelela
Copy link
Contributor

I pasted the json from yaml file as:

{
"guideBlockKey": "OpenChecklist",
"tasks": [
{
"name": "Set My Tag",
"action": "setTag",
"action_data": {
"key": "mytag",
"value": "1234"
}
},
{
"name": "Visit Inbox",
"action": "gotoScreen",
"action_data": {
"deep_link": "airbnbContextual://tab/inbox"
}
},
{
"name": "Visit Profile",
"action": "gotoScreen",
"action_data": {
"deep_link": "airbnbContextual://tab/profile"
}
},
{
"name": "Check User Favourites Count",
"action": "checkTag",
"action_data": {
"key": "favourited_properties_count",
"value": "3",
"type": "int",
"operator": "gte"
}
}
]
}
And got the following:

Screenshot 2024-03-04 at 6 46 45 PM

@amraboelela
Copy link
Contributor

Try again after merging #73 now clicking on the 4th row doesn't make the list to close.
Screenshot 2024-03-04 at 7 16 06 PM

@amraboelela
Copy link
Contributor

I agree Amr, we need a test case to cause the tag to happen, how did you test it and how can QA test?

I tested it by setting the tag through the code, the QA could test it if he can set the tag manually somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants