From 95bf9d69b9665677b70db4acba28d60a7077e7b8 Mon Sep 17 00:00:00 2001 From: Miguel Frias <31300198+MiguelFrias97@users.noreply.github.com> Date: Mon, 20 May 2024 11:56:21 -0700 Subject: [PATCH 1/3] Fixed issue with radio buttons group --- lib/bali/form_builder/radio_fields.rb | 3 +-- spec/dummy/app/javascript/application.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/bali/form_builder/radio_fields.rb b/lib/bali/form_builder/radio_fields.rb index c6cc505e..e7839fbe 100644 --- a/lib/bali/form_builder/radio_fields.rb +++ b/lib/bali/form_builder/radio_fields.rb @@ -96,7 +96,6 @@ def radio_buttons(method, values, options) end def tags(values, html_options, method, label_class) - field_name = [options[:as] || object.model_name.singular, method].join('_') data = html_options.delete(:data) values.map do |display_value| @@ -104,7 +103,7 @@ def tags(values, html_options, method, label_class) radio_options ||= {} radio_options.merge!(html_options) - tag.label(class: label_class, for: [field_name, value].join('_')) do + label(method, class: label_class, value: value) do radio_button(method, value, radio_options.merge(data: data)) + display end end diff --git a/spec/dummy/app/javascript/application.js b/spec/dummy/app/javascript/application.js index 3833a4c2..08485c46 100644 --- a/spec/dummy/app/javascript/application.js +++ b/spec/dummy/app/javascript/application.js @@ -93,7 +93,7 @@ application.register('selected', SelectedController) application.register('auto-play-audio', AutoPlayAudioController) application.register('autocomplete-address', AutocompleteAddressController) application.register('checkbox-toggle-address', CheckboxToggleController) -application.register('datepicker-address', DatepickerController) +application.register('datepicker', DatepickerController) application.register('drawing-maps', DrawingMapsController) application.register('dynamic-fields', DynamicFieldsController) application.register('elements-overlap', ElementsOverlapController) From b3f38120bf2cca12b39e8d4568df11e6753b65ac Mon Sep 17 00:00:00 2001 From: Miguel Frias <31300198+MiguelFrias97@users.noreply.github.com> Date: Mon, 20 May 2024 11:58:19 -0700 Subject: [PATCH 2/3] Updated version --- CHANGELOG.md | 5 +++++ Gemfile.lock | 2 +- lib/bali/version.rb | 2 +- package.json | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7e3aca94..bb3d637e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [1.2.1] - 2024-05-20 + +### Fixed +- Incorrect `for` attribute value in radio buttons of `radio_buttons_field_group` when the value is a datetime + ## [1.2.0] - 2024-05-06 ### Changed diff --git a/Gemfile.lock b/Gemfile.lock index aa48dee4..be00c313 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - bali_view_components (1.2.0) + bali_view_components (1.2.1) caxlsx rails (>= 7.0.2) ransack diff --git a/lib/bali/version.rb b/lib/bali/version.rb index 3656805f..c154bfcd 100644 --- a/lib/bali/version.rb +++ b/lib/bali/version.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true module Bali - VERSION = '1.2.0' + VERSION = '1.2.1' end diff --git a/package.json b/package.json index 006971ef..c453b929 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "bali-view-components", - "version": "1.2.0", + "version": "1.2.1", "description": "Bali ViewComponents", "repository": "git@github.com:Grupo-AFAL/bali.git", "author": "Federico Gonzalez ", From 8b779f85864360bba4767001fb5b5e8f8de0d01f Mon Sep 17 00:00:00 2001 From: Miguel Frias <31300198+MiguelFrias97@users.noreply.github.com> Date: Mon, 20 May 2024 11:58:26 -0700 Subject: [PATCH 3/3] Updated version --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bb3d637e..6967f131 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [1.2.1] - 2024-05-20 ### Fixed -- Incorrect `for` attribute value in radio buttons of `radio_buttons_field_group` when the value is a datetime +- Incorrect `for` attribute value in radio buttons of `radio_buttons_field_group` when value is a datetime ## [1.2.0] - 2024-05-06