Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using fill tool on a raster layer temporarily breaks the graph #2270

Closed
0HyperCube opened this issue Feb 6, 2025 · 1 comment · Fixed by #2398
Closed

Using fill tool on a raster layer temporarily breaks the graph #2270

0HyperCube opened this issue Feb 6, 2025 · 1 comment · Fixed by #2398
Labels
Paper Cut A small UX annoyance we should strive to improve

Comments

@0HyperCube
Copy link
Member

To reproduce:

  • Paste a raster image
  • Select the fill tool
  • Click on the image
  • Observe that the node graph has an error since the fill node does not support the raster input.

Since the tooling should avoid breaking the graph as part of #2214.
@0HyperCube 0HyperCube added the Paper Cut A small UX annoyance we should strive to improve label Feb 6, 2025
@Keavon Keavon added this to Task Board Feb 6, 2025
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Feb 6, 2025
@EllenGYY EllenGYY mentioned this issue Mar 7, 2025
Merged
@EllenGYY
Copy link
Contributor

EllenGYY commented Mar 7, 2025 •
edited by Keavon
Loading

Detect whether the current layer is backed by a raster image. If it is, avoid calling the vector fill function to prevent temporarily breaking the graph. Open PR #2398.

@github-project-automation github-project-automation bot moved this from Short-Term to Completed This Milestone in Task Board Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Paper Cut A small UX annoyance we should strive to improve
Projects
Task Board
Status: Completed This Milestone
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fill tool on raster image temporarily breaks the graph EllenGYY/Graphite
2 participants
@EllenGYY @0HyperCube