Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect snaps when using axis constrained 'compass rose'. #2313

Open
0HyperCube opened this issue Feb 23, 2025 · 7 comments · May be fixed by #2333
Open

Incorrect snaps when using axis constrained 'compass rose'. #2313

0HyperCube opened this issue Feb 23, 2025 · 7 comments · May be fixed by #2333
Labels
Good First Issue Good for newcomers Paper Cut A small UX annoyance we should strive to improve

Comments

@0HyperCube
Copy link
Member

When using the 'compass rose' constrained to an axis, incorrect snaps occur:

Incorrect snap example of a corner snapping to a non existent object

Such snaps do not occur when the layer is dragged on an axis using the shift modifier.
@0HyperCube 0HyperCube added Good First Issue Good for newcomers Paper Cut A small UX annoyance we should strive to improve labels Feb 23, 2025
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Feb 25, 2025
@prathmesh703
Copy link
Contributor

@0HyperCube can i work on this issue?

@Keavon
Copy link
Member

Keavon commented Feb 28, 2025

You're welcome to begin this @prathmesh703.

@prathmesh703
Copy link
Contributor

prathmesh703 commented Feb 28, 2025 •
edited
Loading

@Keavon can you elaborate the issue more?

@Keavon
Copy link
Member

Keavon commented Feb 28, 2025

Let's see what @0HyperCube says.

mTvare6 added a commit to mTvare6/Graphite that referenced this issue Mar 1, 2025
@mTvare6
Fixes constrained snap when using compass axes; Fix line banding
71786dc 
Fixes GraphiteEditor#2313
Fixes line banding[0]

[0]: https://discord.com/channels/731730685944922173/931942323644928040/1345339390809083934
@mTvare6 mTvare6 linked a pull request Mar 1, 2025 that will close this issue
Draft
@mTvare6
Copy link
Contributor

mTvare6 commented Mar 1, 2025

Will be fixed by #2333

@Keavon
Copy link
Member

Keavon commented Mar 1, 2025

Adding a video of this incorrect behavior for clarity: https://files.keavon.com/-/OrganicFirebrickAfricanrockpython/capture.mp4

@0HyperCube is this specifically what you were observing?

@0HyperCube
Copy link
Member Author

@Keavon exactly. The constrained_snap function should be called when dealing with a snap that is constrained along an axis.

Keavon pushed a commit to mTvare6/Graphite that referenced this issue Mar 6, 2025
@mTvare6 @Keavon
Fixes constrained snap when using compass axes; Fix line banding
146a58b 
Fixes GraphiteEditor#2313
Fixes line banding[0]

[0]: https://discord.com/channels/731730685944922173/931942323644928040/1345339390809083934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for newcomers Paper Cut A small UX annoyance we should strive to improve
Projects
Task Board
Status: Short-Term
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes constrained snap when using compass axes; Fix line banding mTvare6/Graphite
4 participants
@Keavon @mTvare6 @0HyperCube @prathmesh703