Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KeyNoRepeat instead of Key to avoid potential user confusion that Tab shouldn't be held in to swap dragged handles #2253

Closed
0HyperCube opened this issue Feb 2, 2025 · 1 comment · Fixed by #2242
Closed

Use KeyNoRepeat instead of Key to avoid potential user confusion that Tab shouldn't be held in to swap dragged handles #2253

0HyperCube opened this issue Feb 2, 2025 · 1 comment · Fixed by #2242
Assignees
@0SlowPoke0
Labels
Paper Cut A small UX annoyance we should strive to improve

Comments

@0HyperCube
Copy link
Member

0HyperCube commented Feb 2, 2025 •
edited by Keavon
Loading

If you are dragging a handle with the path tool, holding Tab makes everything appear to be very buggy due to key repeat, since it's a toggle-based control:
https://github.com/user-attachments/assets/29779385-83f6-4143-95b4-0323bc7bf34f

It would also be worth auditing the editor for other toggle-based controls where accidentally holding the key would result in unintended effects. That has been moved to this issue: #2266
@0HyperCube 0HyperCube added the Paper Cut A small UX annoyance we should strive to improve label Feb 2, 2025
@0HyperCube 0HyperCube changed the title Broken tab to switch handles in the path tool Glitchy holding tab dragging handles in the path tool Feb 2, 2025
@Keavon Keavon changed the title Glitchy holding tab dragging handles in the path tool Use KeyNoRepeat instead of Key to avoid potential user confusion that Tab shouldn't be held in to swap dragged handles Feb 2, 2025
@0SlowPoke0
Copy link
Contributor

I have fixed this, I will add this as a part of another pr

@0SlowPoke0 0SlowPoke0 mentioned this issue Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0SlowPoke0 0SlowPoke0

Labels
Paper Cut A small UX annoyance we should strive to improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the Pen tool's colinearity and equidistance controls 0SlowPoke0/Graphite
2 participants
@0HyperCube @0SlowPoke0