Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 dynamic property warning #104

Open
javiermarinros opened this issue Apr 14, 2023 · 2 comments
Open

PHP 8.2 dynamic property warning #104

javiermarinros opened this issue Apr 14, 2023 · 2 comments
Assignees

Comments

@javiermarinros
Copy link
Contributor

Under PHP 8.2 runtime this notice is emitted

Creation of dynamic property google\appengine\ext\remote_api\Request::$request_id is deprecated in \vendor\google\appengine-php-sdk\src\Ext\RemoteApi\remote_api_pb.php:80

Some more information about PHP 8.2 dynamic properties: https://php.watch/versions/8.2/dynamic-properties-deprecated

@javiermarinros
Copy link
Contributor Author

Just adding extends \stdClass to class \google\net\ProtocolMessage solves the issue and its compatible with older PHP versions.

We need this fix in order to be able to use the SDK in the new PHP 8.2 runtime for AppEngine Standard

@jinglundong

@jinglundong
Copy link
Contributor

jinglundong commented Apr 26, 2023

Ludo, I think we need to reserve (or request additional) capacity for the PHP SDK repo. I'm a bit overloaded at this point.

@ludoch ludoch assigned MontyCarter and unassigned ludoch Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants