Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design File Refactor #2

Closed
kocheck opened this issue Nov 24, 2018 · 3 comments
Closed

Design File Refactor #2

kocheck opened this issue Nov 24, 2018 · 3 comments

Comments

@kocheck
Copy link
Contributor

kocheck commented Nov 24, 2018

Overview

I have been doing some thinking about Githawk and had an idea for the design repo to talk about if you are all up for it!

I would like to suggest a refactor the design files for Githawk. The goals for this update are;

  • An easier system to submit PR requests. And track changes to files in git.
  • icon update, The tab bar icons are not pixel perfect.
  • Rebuild missing screens
  • Refactor/Rename @kocheck sketch symbols from PR Added Profile Screen & Updated Navbar Icons #1 to work more efficiently within the current design system.

Proposed Implementation

- app.sketch (Library)
    ↳ Screens.folder
       - Inbox.sketch
           - Issue.sketch 
       - Search.sketch
           - Repo.sketch
       - Bookmarks.sketch
       - Profile.sketch
       - Settings.sketch 
       - Clickable-Prototype.sketch
- icons PSD
- App-Icon.psd
- REAME.md

App Library

app.sketch becomes the master sketch library file. All master symbols, icons, colors, and type treatments would live here.

The idea is that as a change to a global UI component is approved and added to the app.sketch. file. These changes would trickle down to the different screens. Making smaller changes to the app more trackable.

App Screen Breakout

Breaking out the different screens would make me less nervous as each branch and PR wouldn't be replacing the entirety of the design file each time. Allowing for quick iterations on branches that would (hopefully) be more tractable and easier to maintain. What do ya'll think?

Any ideas, to make this better? @rnystrom If you think this would be helpful I think I might work on this next. 👍

@rnystrom
Copy link
Member

Love every bit of it. I’ve never done any collab with Sketch so I’d love to learn some best practices!

Sent with GitHawk

@kocheck
Copy link
Contributor Author

kocheck commented Nov 24, 2018

Sounds like fun! I think best practices working with sketch in a git repo is still very new. Maybe after Githawk has a good flow is going we should write a Medium article and help set more public concrete Best practices. 😆

Sent with GitHawk

@kocheck
Copy link
Contributor Author

kocheck commented Nov 8, 2024

Hey @rnystrom clearing out old tickets assigned to me. I think we can safely close this 😆

@kocheck kocheck closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants