Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GHC 8.2 #24

Closed
viviag opened this issue Dec 5, 2017 · 3 comments
Closed

Switch to GHC 8.2 #24

viviag opened this issue Dec 5, 2017 · 3 comments

Comments

@viviag
Copy link
Contributor

viviag commented Dec 5, 2017

Update resolver.

Problem: even with most recent resolver it dies (nightly-2017-12-05).
it dies with no error message on stdout (inproc "egrep" [pullExpr] (input gitHistory)) in example.

@viviag
Copy link
Contributor Author

viviag commented Dec 8, 2017

Closed in 881b85b

@viviag viviag closed this as completed Dec 8, 2017
@viviag viviag reopened this Dec 8, 2017
@viviag
Copy link
Contributor Author

viviag commented Dec 8, 2017

Still dies with no error message on the first pipe on the way.
Failing command: view $ inproc "git" ["describe", "--tags", "origin/master"] empty
When trying to use inprocWithErr I see Left ... but it even dies.
It works on a project with tags and fails after.

So it fails while processing empty stream. Test in GHCI:

>view $ inproc "git" ["describe", "--tags"] empty
fatal: Имена не найдены, не могу ничего описать.
*** Exception: ExitFailure 128

Found on tldp.org: 128: Invalid argument to exit

@viviag viviag closed this as completed Dec 8, 2017
@viviag viviag reopened this Dec 8, 2017
@viviag
Copy link
Contributor Author

viviag commented Dec 15, 2017

This is correct behavior of Turtle. Now I can catch exception here. But I would prefer to wait for resolution of members on relevant discussion.
Awaiting Gabriella439/turtle#269

Resolution: use exceptions.
Also it requires switch to git version of Turtle.

@viviag viviag mentioned this issue Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant