Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid USRP environment variable #7

Closed
caaumen opened this issue Sep 3, 2019 · 2 comments
Closed

Invalid USRP environment variable #7

caaumen opened this issue Sep 3, 2019 · 2 comments

Comments

@caaumen
Copy link

caaumen commented Sep 3, 2019

Issue:
docker-redhawk/scripts/usrp.sh sets environment variable USRP_IP in the container.
-e USRP_IP=${USRP_IP:-} \

docker-redhawk/Dockerfiles/files/usrp-node-init.sh expects the environment variable USRP_IP_ADDRESS to be set in the container

	if ! [ -z ${USRP_IP_ADDRESS} ]; then
		print_option IP\: ${USRP_IP_ADDRESS}
		USRP_CONFIG_ARGS="${USRP_CONFIG_ARGS} --usrpip=${USRP_IP_ADDRESS}"
	fi

Effects:
USRP FEI does not set the target_device.ip_address variable inside the USRP node. Without this setting the FEI is unable to find the device.

Recommended solutions:

  1. Change all instances of USRP_IP in the docker-redhawk/scripts/usrp.sh file to USRP_IP_ADDRESS; or
  2. Change all instances of USRP_IP_ADDRESS in the docker-redhawk/Dockerfiles/files/usrp-node-init.sh script to USRP_IP
btgoodwin pushed a commit that referenced this issue Sep 4, 2019
Fix for #7, per caauman there was a mismatch in the environment
variable name vs. what is set in the launcher, scripts/usrp.sh.

Signed-off-by: Thomas Goodwin <[email protected]>
@btgoodwin
Copy link
Contributor

Thanks for the call-out on this. Rather than modify the init script (which would require rebuilding the image), I took your first suggestion to patch the launcher script (see: 780e696). Please let me know if that resolves it for you.

@caaumen
Copy link
Author

caaumen commented Sep 12, 2019

Tested and works as expected. Unfortunately we found a new unrelated issue: Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants