-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify checks like "x is not None or y is not None or z is not None" #2816
Conversation
Do we want to have this simplifications only for 3 checks like
or also for 2 checks like:
? |
I feel it's not necessary to rewrite 2-checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably also the lines 194-197 can be rewritten using any
:
Lines 192 to 200 in 579ad70
# Build the -F option in gmt text. | |
if kwargs.get("F") is None and ( | |
position is not None | |
or angle is not None | |
or font is not None | |
or justify is not None | |
): | |
kwargs.update({"F": ""}) | |
(I am sorry in case my post at #2757 (comment) was misleading. It was meant only as a question whether I understood this issue correctly, not as a complete update of the Figure.text
method.)
/format |
/format |
Description of proposed changes
Related to #2757
Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version