-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.grdimage: Let the img_out parameter work as documented #2765
Conversation
This PR works well for me locally on macOS, but I have no idea why it fails on CI. |
Is this only for GMT 6.5? Doesn't work locally for me with GMT 6.4.0 on Linux. |
This reverts commit ad18823.
Co-authored-by: Yvonne Fröhlich <[email protected]>
Running the
but it causes crashes if running with the
|
As reported in #2599 (comment), now the |
Ping @GenericMappingTools/pygmt-maintainers Please see #2599 for the related discussions, especially comments like #2599 (comment) and #2599 (comment). The grdimage module usually writes PostScript codes to a hidden PostScript file, but with As mentioned in #2599 (comment), So, I propose to:
Thoughts? |
Sound good. So we're removing the alias without a deprecation cycle right? Since it didn't really work before? |
Yes, but I think it's better to raise a warning/error if |
Superseded by #2907. Closing. |
Description of proposed changes
grdimage
-A
option works diffenrently for GMT CLI and external wrappers.For GMT CLI, the syntax is like
gmt grdimage ingrd.nc -Aimg_out.xxx
.For external wrappers, the syntax is like
gmt grdimage ingrid.nc -A > img_out.xxx
.This PR makes
img_out
parameter working as documented, i.e.,img_out="out.tiff"
works.Address #2599.