Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Engs] Update nav bar #486

Open
26 tasks
racheledelman opened this issue Feb 25, 2025 · 1 comment
Open
26 tasks

[Engs] Update nav bar #486

racheledelman opened this issue Feb 25, 2025 · 1 comment
Labels
story User story

Comments

@racheledelman
Copy link

Overview

As a builder, I would like links to each of the pages in the platform, so that I can access them.

Context

As we refine our overall user flow, we need to update the nav bar contents.

Image

Acceptance Criteria

Required outcomes of the story

  • There is a "Create Forms" item that goes to /create-form
  • "My forms" is renamed to "View and Edit Forms" (goes to /forms)
  • There is a "Forms Index" item that goes to wherever the Forms Index lives (this can be hidden until this feature is live)
  • The header adheres to the USWDS standard (which for example, does not include a border under the nav items)
  • The Storybook link does not appear on the live site

Research Questions

  • Optional: Any initial questions for research

Tasks

Research, design, and engineering work needed to complete the story.

  • [ ]

Definition of done

The "definition of done" ensures our quality standards are met with each bit of user-facing behavior we add. Everything that can be done incrementally should be done incrementally, while the context and details are fresh. If it’s inefficient or “hard” to do so, the team should figure out why and add OPEX/DEVEX backlog items to make it easier and more efficient.

  • Behavior
    • Acceptance criteria met
    • Implementation matches design decisions
  • Documentation
    • ADRs (/documents/adr folder)
    • Relevant README.md(s)
  • Code quality
    • Code refactored for clarity and no design/technical debt
    • Adhere to separation of concerns; code is not tightly coupled, especially to 3rd party dependencies; dependency rule followed
    • Code is reviewed by team member
    • Code quality checks passed
  • Security and privacy
    • Automated security and privacy gates passed
  • Testing tasks completed
    • Automated tests pass
    • Unit test coverage of our code >= 90%
  • Build and deploy
    • Build process updated
    • API(s) are versioned
    • Feature toggles created and/or deleted. Document the feature toggle
    • Source code is merged to the main branch

Decisions

  • Optional: Any decisions we've made while working on this story
@racheledelman racheledelman added the story User story label Feb 25, 2025
@racheledelman
Copy link
Author

@nichole-aquino right now the builder has two links to "My forms", one in the global nav bar, and one in the builder header (which is sticky).

Image

This seems duplicative. Any thoughts on whether we should keep both, remove the one in the header, or not show the nav bar in the builder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story User story
Projects
None yet
Development

No branches or pull requests

1 participant