From ef8c28396b3e6263aa904edeaed98e405a01b8f0 Mon Sep 17 00:00:00 2001 From: Ethan Gardner Date: Fri, 17 Jan 2025 15:49:29 -0500 Subject: [PATCH] fix issue where pnpm test was not terminating on test completion (#451) Without the env var, the storybook browser tests kept the web socket connection open indefinitely, causing our pre-commit hooks to never exit and blocking commits unless we ran it with --no-verify --- .husky/pre-commit | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.husky/pre-commit b/.husky/pre-commit index c7760777..8db69672 100644 --- a/.husky/pre-commit +++ b/.husky/pre-commit @@ -1,4 +1,4 @@ #!/bin/sh pnpm lint pnpm format -pnpm test +pnpm test:ci diff --git a/package.json b/package.json index c2d3bc67..b0c4bbb6 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "lint": "turbo run lint", "pages": "rm -rf node_modules && npm i -g pnpm turbo && pnpm i && pnpm build && ln -sf ./apps/spotlight/dist _site", "test": "vitest run", - "test:ci": "vitest run # --coverage.enabled --coverage.provider=v8 --coverage.reporter=text --coverage.reporter=json-summary --coverage.reporter=json --coverage.reportOnFailure", + "test:ci": "CI=true vitest run # --coverage.enabled --coverage.provider=v8 --coverage.reporter=text --coverage.reporter=json-summary --coverage.reporter=json --coverage.reportOnFailure", "test:infra": "turbo run --filter=infra-cdktf test", "typecheck": "tsc --build --noEmit", "prepare": "husky"