Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in behavior of Service::Customer#fetch_by_id between QBD and QBO #10

Open
mcmire opened this issue Oct 11, 2013 · 0 comments

Comments

@mcmire
Copy link

mcmire commented Oct 11, 2013

When requesting a customer by id and it is not found, Windows will return nil, but Online will throw an error. We should either throw an error or return nil in both cases. I would personally return nil -- there is no reason to make calling code blow up, especially since this never occurs when returning a list a customers and the list happens to be empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant