Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more advanced optimisation for determining P and D value in V1 gas price algorithm #2181

Open
1 of 2 tasks
MitchTurner opened this issue Sep 9, 2024 · 0 comments · May be fixed by #2538
Open
1 of 2 tasks

Use more advanced optimisation for determining P and D value in V1 gas price algorithm #2181

MitchTurner opened this issue Sep 9, 2024 · 0 comments · May be fixed by #2538

Comments

@MitchTurner
Copy link
Member

MitchTurner commented Sep 9, 2024

We are currently just choosing a bunch of random values and whichever values give the lowest "error" is returned.

We can improve in a number of ways:

  • We can do some sort of gradient descent to find better values. We still need to do random sampling as well in case there are local minima, but from there we can do gradient descent.
  • We can do a multi-threaded optimization (completed as part of bug: fix algorithm overflow issues #2173)

We should also redefine "error". Currently it's defined as as the sum of abs(profit) for each block. It's possible we are running in to overflows for the larger sets.

@MitchTurner MitchTurner linked a pull request Jan 15, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant