Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retriving delayed actions hydrated from DB after init causes api calls to reddit #137

Open
FoxxMD opened this issue Jan 5, 2023 · 0 comments
Assignees
Labels
bug Something isn't working DB DB specific problem

Comments

@FoxxMD
Copy link
Owner

FoxxMD commented Jan 5, 2023

Delayed action entities do not store all of the associated activity's data (and don't use the existing Activity entity).

When a user visits the dashboard of a newly-started CM instances that has hydrated actions from the DB CM serializes some of the activity info including permalink which is NOT stored in the db. Subsequently, accessing this property causes snoowrap to causes a full fetch for each activity. This drastically impacts CM api usage and performance:

  • number of api calls used in 1:1 with number of delayed actions
  • UI hangs while all activities are fetched

Solution for this is using existing Activity entity to store dispatched activity info. #136 is a partial implementation for this which also checks that Activities associated with existing Check/Run results isn't deleted after the delayed activity is run.

@FoxxMD FoxxMD added bug Something isn't working API CM API (server or client) labels Jan 5, 2023
@FoxxMD FoxxMD self-assigned this Jan 5, 2023
@FoxxMD FoxxMD added DB DB specific problem and removed API CM API (server or client) labels Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DB DB specific problem
Projects
None yet
Development

No branches or pull requests

1 participant