Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxes ore dictionary issues #12

Open
Jomosoto opened this issue Apr 2, 2023 · 0 comments
Open

Boxes ore dictionary issues #12

Jomosoto opened this issue Apr 2, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Jomosoto
Copy link
Member

Jomosoto commented Apr 2, 2023

Describe the bug

  • Boxes can only require a preset list of ore dictionary items
  • Ore dictionary items are never found and the fallback is always used
  • Treated Planks is not found and not replaced, if immersive engineering is not present

To Reproduce
Steps to reproduce the behaviour:

  1. Take a mod that introduces steel, like Galacticraft
  2. Add ingotSteel to the requirements of any item
  3. Try to craft the item; observe that it demands iron not steel
  4. Try to craft an item, that needs treated wood planks; observe that the planks are not required

Expected behaviour

  • All ore dictionary items should be supported
  • It should be possible to use ore dictionary items, it should not always be the fallback
  • Treated planks should correctly fallback on normal wood

Screenshots

Versions (please complete the following information)

  • Forge: 14.23.5.2768
  • Flan's Mod: 1.12.2 branch (at 425eee3)

Additional context

Thanks to @JT2AW15 for reporting this issue. He already provided a PR that fixes some of the issues: FlansMods#1423. With his permission, this could be used as a base to fix this issue.

@Jomosoto Jomosoto added the bug Something isn't working label Apr 2, 2023
@Jomosoto Jomosoto self-assigned this Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant