Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Log last line Overlap/Overflow #137

Closed
Marco-Zechner opened this issue Jul 15, 2024 · 1 comment
Closed

Ship Log last line Overlap/Overflow #137

Marco-Zechner opened this issue Jul 15, 2024 · 1 comment
Labels
bug Something isn't working external Depends on some other mod
Milestone

Comments

@Marco-Zechner
Copy link

Describe the bug
A clear and concise description of what the bug is.

The log that was last added (if the screen is already full) is always outside of the area.
For 1 line log behind the bottom text.
For 2 line log the first line is behind the bottom text and the second is completely outside and not visible

KSP.log file
ALL BUG REPORTS MUST INCLUDE A KSP.LOG FILE
KSP.log

To Reproduce
Steps to reproduce the behaviour:

  1. Build a ship with enough parts to fill the ship log.
  2. Do an action that produces a ship log.
  3. The new Ship log will be behind the bottom text or a part outside the screen.

Expected behaviour
A clear and concise description of what you expected to happen.

  • Scrolling through the logs with the up/down buttons.
  • The text moves up, removes old logs and shows the new.
    (The "new" log DOES move up, but only when another new one is below in the non-readable space)

Screenshots
If applicable, add screenshots to help explain your problem.
image

Desktop (please complete the following information):

  • OS: Windows 10

Additional context
Add any other context about the problem here.

@Marco-Zechner Marco-Zechner added the bug Something isn't working label Jul 15, 2024
@JonnyOThan JonnyOThan added this to the 1.0.0 milestone Aug 5, 2024
@JonnyOThan
Copy link
Collaborator

This needs to be fixed in ASET props.

				pageTitle = $$$============= Flight Log ==================
				screenWidth = 40
				screenHeight = 18

The $$$ there is a line break, which makes sure the page title appears below the top row of button labels. There's also a bottom row of button labels. The full display is 20 lines tall, so screenHeight needs to be 17 not 18.

@JonnyOThan JonnyOThan closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2024
@JonnyOThan JonnyOThan added the external Depends on some other mod label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Depends on some other mod
Projects
None yet
Development

No branches or pull requests

2 participants