-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply SPDX information to files #746
Comments
Given the requirements in the REUSE Specification, |
The REUSE Specification may require further changes to the headers than those listed right now under points 1 and 2, and may affect point 5. This needs to be investigated further. |
Deferring this until some future version. |
mrotteveel
added a commit
that referenced
this issue
Jan 21, 2025
mrotteveel
added a commit
that referenced
this issue
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the SPDX identifier of Jaybird is listed in README.md. Expand this to all files and the JAR itself.
Things to do (NOTE: this is not necessarily the order these operations should be performed):
Replace current LGPL license notice in individual source files with
Note the removal of "This file was created by members of the firebird development team.", as this is not always true: some files are or were created by outside contributors.
Before applying this change, double check if removing the current header is appropriate and allowed by their respective licenses, otherwise the SPDX identifier should be added to the current header, instead of the header replaced.
Replace current BSD-3 clause license notice in individual source files with:
or, as we claim the intent is to dual-license these API interfaces/classes, but the current license header doesn't do that, check if we can do (as in, are we authorized to expand the license given those historic claims, or does the actual license prevail; taking into account historic authorship):
If this is appropriate, the global SPDX identifier becomes "LGPL-2.1-or-later OR LGPL-2.1-or-later AND BSD-3-Clause" instead of "LGPL-2.1-or-later AND BSD-3-Clause".
Before applying this change, double check if removing the current header is appropriate and allowed by their respective licenses, otherwise the SPDX identifier should be added to the current header, instead of the header replaced.
Replace or rename
LICENSE
withLICENSES/GPL-2.1-or-later.txt
with the appropriate text (and make sure it is appropriately included in the JAR/dist-zip) (NOTE: Currently the directory is namedlicenses
, and must be renamed toLICENSES
)Add
LICENSES/BSD-3-Clause.txt
with the appropriate text (and make sure it is appropriately included in the JAR/dist-zip)Check how to handle some of the "separately" licensed files (only LegacyHash.java comes to mind right now, there might be more), and its effects on the SPDX identifier
If point 2 or 5 changes the global identifier, update the README.md, and check if we also need to change information elsewhere (e.g. with Tidelift)
Add
Bundle-License: LGPL-2.1-or-later AND BSD-3-Clause
to the JAR manifest (see also point 2 and 5, identifier may change)Maybe add a new LICENSE.txt or LICENSE file explaining licensing structure and referring to the individual license files
Check if and how we can include the SPDX identifier in the POM and Gradle modules file generated by Gradle
Create a JDP document detailing licensing and how to include the license information in individual files
The text was updated successfully, but these errors were encountered: