From 451b02d2562eabab75263945b52c5dbf970bfadb Mon Sep 17 00:00:00 2001 From: Naseem Ali <34807727+Naseem77@users.noreply.github.com> Date: Fri, 31 Jan 2025 19:01:50 +0200 Subject: [PATCH] fix failing tests --- e2e/logic/POM/codeGraph.ts | 13 ++++--------- e2e/tests/navBar.spec.ts | 4 ++-- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/e2e/logic/POM/codeGraph.ts b/e2e/logic/POM/codeGraph.ts index 4ee1a0b..38e9c10 100644 --- a/e2e/logic/POM/codeGraph.ts +++ b/e2e/logic/POM/codeGraph.ts @@ -259,13 +259,11 @@ export default class CodeGraph extends BasePage { } async clickOnTipBtn(): Promise { - const isVisible = await waitForElementToBeVisible(this.tipBtn); - if (!isVisible) throw new Error("'Tip' button is not visible!"); await this.tipBtn.click(); } async isTipMenuVisible(): Promise { - // await this.page.waitForTimeout(500); + await this.page.waitForTimeout(500); return await waitForElementToBeVisible(this.genericMenu); } @@ -454,19 +452,16 @@ export default class CodeGraph extends BasePage { } async clickOnRemoveNodeViaElementMenu(): Promise { - await this.elementMenu.waitFor({ state: "visible", timeout: 10000}) - const button = this.elementMenuButton("Remove"); + const button = this.elementMenuButton("Remove"); + const isVisible = await waitForElementToBeVisible(button); + if (!isVisible) throw new Error("'View Node' button is not visible!"); await button.click(); } async nodeClick(x: number, y: number): Promise { - await this.page.waitForTimeout(500); - console.log(`Clicking node at: X=${x}, Y=${y}`); await this.canvasElement.hover({ position: { x, y } }); await this.page.waitForTimeout(500); // Allow hover to take effect - console.log("Hover successful"); await this.canvasElement.click({ position: { x, y }, button: 'right' }); - console.log("Right-click performed"); } async selectCodeGraphCheckbox(checkbox: string): Promise { diff --git a/e2e/tests/navBar.spec.ts b/e2e/tests/navBar.spec.ts index 9f294a7..f282ca0 100644 --- a/e2e/tests/navBar.spec.ts +++ b/e2e/tests/navBar.spec.ts @@ -41,9 +41,9 @@ test.describe(' Navbar tests', () => { test("Validate Tip popup visibility and closure functionality", async () => { const navBar = await browser.createNewPage(CodeGraph, urls.baseUrl); - await navBar.clickonTipBtn(); + await navBar.clickOnTipBtn(); expect(await navBar.isTipMenuVisible()).toBe(true); - await navBar.clickonTipMenuCloseBtn(); + await navBar.clickOnTipMenuCloseBtn(); expect(await navBar.isTipMenuVisible()).toBe(false); }); });