From acf9fb2ab25b7edc6e7b4a06a2479804ebb277c8 Mon Sep 17 00:00:00 2001 From: mbackes Date: Wed, 30 Aug 2023 14:58:19 -0700 Subject: [PATCH 1/2] logger to log to stdout --- sdk/python/feast/expediagroup/vectordb/__init__.py | 0 .../feast/expediagroup/vectordb/milvus_online_store.py | 8 ++++++++ 2 files changed, 8 insertions(+) create mode 100644 sdk/python/feast/expediagroup/vectordb/__init__.py diff --git a/sdk/python/feast/expediagroup/vectordb/__init__.py b/sdk/python/feast/expediagroup/vectordb/__init__.py new file mode 100644 index 0000000000..e69de29bb2 diff --git a/sdk/python/feast/expediagroup/vectordb/milvus_online_store.py b/sdk/python/feast/expediagroup/vectordb/milvus_online_store.py index afd37d6400..b41807d5bd 100644 --- a/sdk/python/feast/expediagroup/vectordb/milvus_online_store.py +++ b/sdk/python/feast/expediagroup/vectordb/milvus_online_store.py @@ -1,5 +1,6 @@ import json import logging +import sys from datetime import datetime from typing import Any, Callable, Dict, List, Optional, Sequence, Tuple @@ -37,6 +38,13 @@ from feast.usage import log_exceptions_and_usage logger = logging.getLogger(__name__) +# todo this might be better placed on module or project level +logging.basicConfig(level=logging.INFO) +handler = logging.StreamHandler(sys.stdout) +handler.setLevel(logging.INFO) +formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s') +handler.setFormatter(formatter) +logger.addHandler(handler) TYPE_MAPPING = bidict( { From 62bb00d9f229a5c7c0a878a2de15479cca788574 Mon Sep 17 00:00:00 2001 From: mbackes Date: Wed, 30 Aug 2023 15:00:32 -0700 Subject: [PATCH 2/2] fixed formatting --- sdk/python/feast/expediagroup/vectordb/milvus_online_store.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/python/feast/expediagroup/vectordb/milvus_online_store.py b/sdk/python/feast/expediagroup/vectordb/milvus_online_store.py index b41807d5bd..d0e7320660 100644 --- a/sdk/python/feast/expediagroup/vectordb/milvus_online_store.py +++ b/sdk/python/feast/expediagroup/vectordb/milvus_online_store.py @@ -42,7 +42,7 @@ logging.basicConfig(level=logging.INFO) handler = logging.StreamHandler(sys.stdout) handler.setLevel(logging.INFO) -formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s') +formatter = logging.Formatter("%(asctime)s - %(name)s - %(levelname)s - %(message)s") handler.setFormatter(formatter) logger.addHandler(handler)