Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the code in phase2/eval.py wrong? #7

Open
hejiaget opened this issue Dec 27, 2018 · 0 comments
Open

Is the code in phase2/eval.py wrong? #7

hejiaget opened this issue Dec 27, 2018 · 0 comments

Comments

@hejiaget
Copy link

hejiaget commented Dec 27, 2018 •
edited
Loading

The code in line 162 in phase2/eval.py :

true_top5_predictions_count+= top5_accuracy
true_top3_predictions_count+= top3_accuracy
one_bin_off_val+= obol_val

print(batch_format_str%(step, '[' + ', '.join('%.3f' % (item/(step+1.0)) for item in true_predictions_count) + ']', true_top5_predictions_count/(step + 1.0), true_top3_predictions_count/(step+1.0), obol_val/(step+1.0), accv_all/total_examples, prcv_all/total_examples, recv_all/total_examples))

I think the bold code obol_val is not right, but should be one_bin_off_val. Am I right?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hejiaget