Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Validate checkers ordered with "checker" prefix #4409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noraz31
Copy link
Collaborator

@noraz31 noraz31 commented Dec 15, 2024

CC validates ordered checkers before analyzing, but didn't use to validate the checkers ordered with the "checker:" prefix. With this fix, those will be validated as well.
Fixes #4405

@cservakt
Copy link
Collaborator

What about the prefix: namespace? We sould give an error if the prefix:invalid-option given. I think it would be better to find a solution for both.

@noraz31 noraz31 force-pushed the checker_prefix_fix branch from 1e1a713 to 89a1b1a Compare January 6, 2025 15:29
@noraz31 noraz31 marked this pull request as draft January 7, 2025 07:50
CC validates ordered checkers before analyzing, but didn't use to
validate the checkers ordered with the "checker:" or "prefix:"
option. With this fix, all ordered checkers will be validated.
Fixes Ericsson#4405
@noraz31 noraz31 force-pushed the checker_prefix_fix branch from 89a1b1a to 19bddf8 Compare January 8, 2025 08:43
@noraz31 noraz31 marked this pull request as ready for review January 8, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enabling non existing checker does not give an error
2 participants