Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of EBI Biome terms #672

Closed
kaiiam opened this issue Feb 28, 2019 · 7 comments
Closed

Creation of EBI Biome terms #672

kaiiam opened this issue Feb 28, 2019 · 7 comments
Assignees
Labels
enhancement GOLD/EBI-MGNIFY Genomes OnLine Database GOLD Vocabulary mapping

Comments

@kaiiam
Copy link
Contributor

kaiiam commented Feb 28, 2019

I have been tasked with the creation of ENVO terms for the EBI biomes hierarchy, so that EBI which can better link to ENVO. They have major biome hierarcies for environmental, host-associated, and engineered systems. I have created a spreadsheet for the Environmental biomes hierarchy which has columns for

environmental feature environmental material (or material entity for CHEBI, FOODON or other) environmental system

Perhaps we could create yaml patterns for each of the major biome types, starting with Environmental.

@cmungall
Copy link
Member

cmungall commented Feb 28, 2019

We also need to include mappings to the EBI terms. these don't have IDs, but can be identified by > Foo > Bar > Baz descriptors. Normally we would do mappings as xrefs but xrefs should be IDs with no spaces, so maybe we want to a specific property here.

Or we could do these as synonyms.

Either way, it is easy to export as a simple TSV as part of each release

@pbuttigieg
Copy link
Member

We need something more permissive than xrefs if they don't allow anything other than IDs, and we need this OBO-wide

@pbuttigieg
Copy link
Member

pbuttigieg commented Mar 5, 2019

Perhaps @mscheremetjew, @olatarkowska, or @mb1069 from over at https://github.com/EBI-Metagenomics / https://github.com/EBI-Metagenomics/ebi-metagenomics-webkit can help:

Do the EBI biomes have IRIs or some other kind of web-accessible ID?
Is this valid: https://www.ebi.ac.uk/metagenomics/browse?lineage=root:Environmental:Aquatic:Marine

or is there something more compact? What would the URL/IRI be for something more fine grain (like "Coastal")?

@mb1069
Copy link

mb1069 commented Mar 6, 2019

Gladly! Our biomes are constructed as colon separated strings, though these can sometimes contain spaces (eg: root:Engineered:Wastewater:Activated Sludge). We also have duplicated biome names which is why we not yet investigated a simplified biome URI (eg root:Engineered:Solid waste:Composting:Bioreactor and root:Engineered:Solid waste:Composting:Wood:Bioreactor). So @pbuttigieg you have a correct URI, though this is also exposed via our API (https://www.ebi.ac.uk/metagenomics/api/latest/biomes?lineage=root:Environmental:Aquatic:Marine)

@cmungall
Copy link
Member

cmungall commented Mar 6, 2019 via email

@pbuttigieg
Copy link
Member

Many thanks @mb1069 ! Our work here (Rob's in the loop on this) aims to give you another tool to do this with semantic web tech.

OK, thanks! In this case we should encode the xref with identical fragment
to the URL, e.g. MGNIFY:Foo:Bar:Baz+Biz, or we can just use the URL
directly as the xref (these should get translated to equivalence axioms in
the release)

@cmungall I'm more a fan of the whole URL so there's something actionable right away.

kaiiam added a commit that referenced this issue Mar 22, 2019
Addressing  PR #735 and issue  #672 I have proposed the following changes. Please merge if correct or modify.
kaiiam added a commit that referenced this issue Apr 28, 2019
Due to merge conflicts, I will remake  remake PR #736 here in to address PR #735 and issue #672.
@kaiiam kaiiam self-assigned this May 27, 2019
@kaiiam kaiiam added the GOLD/EBI-MGNIFY Genomes OnLine Database GOLD Vocabulary label Aug 16, 2019
@pbuttigieg
Copy link
Member

Obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement GOLD/EBI-MGNIFY Genomes OnLine Database GOLD Vocabulary mapping
Projects
None yet
Development

No branches or pull requests

4 participants