Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ENVO:alga replaced by PCO:alga excluding Cyanobacteria? #1046

Open
kaiiam opened this issue Nov 23, 2020 · 9 comments
Open

Deprecate ENVO:alga replaced by PCO:alga excluding Cyanobacteria? #1046

kaiiam opened this issue Nov 23, 2020 · 9 comments
Assignees

Comments

@kaiiam
Copy link
Contributor

kaiiam commented Nov 23, 2020

@ramonawalls in PopulationAndCommunityOntology/pco#58 created the new term: alga excluding Cyanobacteria to replace envo: alga. Also xref EcologicalSemantics/ecocore#100.

Unless @pbuttigieg has any objections, should we precede to deprecate and replace by?

@kaiiam kaiiam self-assigned this Nov 23, 2020
@cmungall
Copy link
Member

I don't think this belongs in either

@kaiiam
Copy link
Contributor Author

kaiiam commented Nov 23, 2020

@cmungall should this be in COB instead?

@cmungall
Copy link
Member

no, it's not upper level.

In GO we mint a taxon_union namespace which is terrible as it doesn't resolve

we need a new namespace and sync this with ncbitaxon releases and use the go union patterns

@kaiiam
Copy link
Contributor Author

kaiiam commented Nov 23, 2020

I'd be interested in trying to help with this effort @cmungall can you direct me to these go union patterns?

@cmungall
Copy link
Member

@cmungall
Copy link
Member

anyway, deprecate in envo and close this for now

@kaiiam
Copy link
Contributor Author

kaiiam commented Nov 23, 2020

@cmungall perhaps we can deprecate in ENVO once we have something to replace it by. I'd prefer not to leave downstream projects without a term in the interim.

@pbuttigieg
Copy link
Member

pbuttigieg commented Nov 23, 2020

@kaiiam agreed, also agreed it's a strange one.

Let's deprecate and add replaced by as you suggested.
If there's downstream work to do in deprecating those, it can happen in PCO/ECOCORE

@kaiiam
Copy link
Contributor Author

kaiiam commented Nov 23, 2020

Following @pbuttigieg's suggestion for now will be possible once PCO has made it's next release @ramonawalls please let me know when you do so, such that I can import it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants