Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The naming of the component tab for this project is inconsistent with others #1

Closed
peardox opened this issue Oct 12, 2022 · 14 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@peardox
Copy link

peardox commented Oct 12, 2022

Everything else is Python [[ - ] Subproject]

This one therefore looks 'wrong' - there's nothing actually wrong of course (I must have a bit of OCD I wasn't aware of)

Look...

pp4d

@lmbelo lmbelo self-assigned this Oct 15, 2022
@lmbelo lmbelo added the enhancement New feature or request label Oct 15, 2022
@lmbelo
Copy link
Member

lmbelo commented Oct 15, 2022

Let's figure out a good name. Any suggestion?

@peardox
Copy link
Author

peardox commented Oct 15, 2022

Python - Extra Packages?

The Dash is what really bothers me :)

@peardox
Copy link
Author

peardox commented Oct 15, 2022

The location of lib and images also appears to be 'floating' - these should really be consistant - personally I prefer src to ONLY contain source with lib and images being off project root

See Embarcadero/P4D-Data-Sciences#23

I'm currently writing a little Wizard - it was either write the six components I need or write a Wizard, Wizard is a better bet so doing that. ATM I don't quite know where I should put lib and images is both in src and root in this package. I think I'll go for an off-root structure unless anyone has a good reason not to.

@peardox
Copy link
Author

peardox commented Oct 30, 2022

Can't assign myself - well, done it

@lmbelo
Copy link
Member

lmbelo commented Oct 31, 2022

What is all these .drpoj modifications? It is not supposed to be changed.

@lmbelo lmbelo closed this as completed Oct 31, 2022
@Priyatham10
Copy link
Member

I can think of a name. Say, Python - PIP Packages for Delphi. This solves the consistency of naming convention with - after Python like others and also saying these are PIP packages provided as components for direct use.

@lmbelo
Copy link
Member

lmbelo commented Oct 31, 2022

@Priyatham10 these are not PIP only intended packages.

@peardox
Copy link
Author

peardox commented Oct 31, 2022

Did all my Linux Activations just get wiped?

@lmbelo
Copy link
Member

lmbelo commented Oct 31, 2022

There were too many modifications in a single commit. Try to break it down into smaller commits and splitted pull requests. It gets much easier to review.

@peardox
Copy link
Author

peardox commented Oct 31, 2022

Moving lib back to the root involves very small changes to a lot of files and they have to all be done or none done.

There are two files that need changes per component : src/Component/P4DComponent.dproj + src/Component/dclP4DComponent.dproj - this repo has 7 components so 14 files need altering for everything to move back to /lib

Renaming the palette page has to be done for each ComponentReg.pas - again, all or nothing

When Jim moved everything around there would have been a lot more changes that this PR

The only alternative would be individual PRs for each component but no individual PR would produce one lib and one palette

@peardox
Copy link
Author

peardox commented Oct 31, 2022

Oh, enabling Linux will also have changed a lot of files... 29 at a guess

@lmbelo
Copy link
Member

lmbelo commented Oct 31, 2022

I understand. As you changed it, other settings were changed as well.

@peardox
Copy link
Author

peardox commented Oct 31, 2022

I can write you a step-by-step what to change - it's probably quicker than a huge PR for both of us :)

The actual changes are really simple (took me a few hours to work them all out though)

@lmbelo
Copy link
Member

lmbelo commented Oct 31, 2022

Yes, sure. Describe it here and I will do it right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants