Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch with rust-bitcoin version "0.32" #208

Closed
RCasatta opened this issue Aug 13, 2024 · 1 comment
Closed

Branch with rust-bitcoin version "0.32" #208

RCasatta opened this issue Aug 13, 2024 · 1 comment

Comments

@RCasatta
Copy link
Collaborator

Blockstream/electrs#91 (comment)
@RCasatta RCasatta changed the title Branch with rust-bitcoin version "0.32.0-rc1" Branch with rust-bitcoin version "0.32" Aug 14, 2024
@RCasatta RCasatta mentioned this issue Aug 14, 2024
Merged
@RCasatta RCasatta mentioned this issue Aug 26, 2024
Closed
apoelstra added a commit that referenced this issue Aug 26, 2024
@apoelstra
Merge #209: upgrade to bitcoin 0.32
85604b0 
f889525 improve logging on error (Riccardo Casatta)
802c006 upgrade bitcoin 0.31 -> 0.32, fix test env vars (Riccardo Casatta)

Pull request description:

  #208

  ```
      fn consensus_encode<W: bitcoin::io::Write + ?Sized>(&self, e: W) -> Result<usize, crate::encode::Error> {}
      fn consensus_decode<R: bitcoin::io::BufRead + ?Sized>(reader: &mut R) -> Result<Self, crate::encode::Error> {}
  ```

  We went for not depending on bitcoin::Encodable instead

ACKs for top commit:
  apoelstra:
    ACK f889525 successfully ran local tests

Tree-SHA512: 23fbf597c7adad52c40f1c26b2d0cad6755a0ff8f9da3ee498d2dd80856b24f557f2f7bf504712a6d25e358d5417fc5f7c467122470d9087f93f1e7d260e5539
@RCasatta
Copy link
Collaborator Author

Done in #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RCasatta