Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nativescript 6.0 #62

Open
amlibtest opened this issue Jul 22, 2019 · 5 comments
Open

Add support for nativescript 6.0 #62

amlibtest opened this issue Jul 22, 2019 · 5 comments

Comments

@amlibtest
Copy link

amlibtest commented Jul 22, 2019

With nativescript 6.0, service $platformsData has been renamed to $platformsDataService and hookArgs structure has also changed, for example.

https://www.nativescript.org/blog/migrating-cli-hooks-to-nativescript-6.0

@darxmac
Copy link

darxmac commented Aug 23, 2019

I tried to hack my way to make it work in NativeScript 6, but ran into a few walls. Anyone have a workaround that actually works ?

@dosomder
Copy link

dosomder commented Nov 4, 2019

@EddyVerbruggen any news on this?

@EddyVerbruggen
Copy link
Owner

Not by me yet, but it's not too hard to adjust those hooks (a lot of plugins had to change their hook code), and a PR is more than welcome considering my endless pile of other stuff to work on.

@dosomder
Copy link

dosomder commented Nov 4, 2019

I did patch the hook but then I get the error

Cannot find module 'C:\Users\hue\Documents\GitHub\hue\platforms\android\app\src\main\assets\app\tns_modules\nativescript-nodeify\patch-npm-packages.js'

The folder tns_modules does not exist in this path.

@jedatu
Copy link

jedatu commented Nov 11, 2019

I am seeing the same error that @dosomder is seeing.

This is the line in patch-platforms.js that is failing.

var patchNpmPackage = require(patchNpmPackageDir);

The script expects to find patch-npm-packages.js under the tns_modules/nativescript-nodeify directory. The file exists in the nativescript-nodeify directory under the project's root node_modules, however none of the node dependencies are being copied to the tns_modules directory. Did something change in NS6 such that the dependencies are not staged in tns_modules during the prepare phase?

This is related to supporting webpack which is described in Issue #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants