Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] Default profile image text should be visible in dark mode #9900

Closed
1 task done
j-grosse opened this issue Dec 12, 2023 · 7 comments
Closed
1 task done

[BUG] Default profile image text should be visible in dark mode #9900

j-grosse opened this issue Dec 12, 2023 · 7 comments
Labels
🛠 goal: fix undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 💬 talk: discussion undefined

Comments

@j-grosse
Copy link

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

https://www.biodrop.io/EddieHubCommunity?tab=testimonials

Version of BioDrop (for example "v1.2.3")

v2.95.1

Description

When activating dark mode the grey text in the default profile picture (which is some text) changes to white.
This makes the text (on the white background) disappear.
It is still there as it can be selected, see screenshot.

Steps to Reproduce

  1. Go to the page's testimonial tab
  2. change from light mode to dark mode via sun/moon symbol in top right page menu
  3. Now the profile picture text of user "LinuxGamer" disappears (but can still be selected)

Screenshots

by default 2023-12-12 at 15 22 08

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No, as I don't know how to solve this exactly.
When inspecting the profile picture in Google Chrome I see that the style attribute of the img tag ist not set.
In the other profile pictures that are actual images and not text, it is set to style="color: transparent;".
If I add style="color: black;" inside of the inspected img tag, the profile picture becomes visible.
Maybe an automatically added default placeholder profile image instead of default text would be the solution. It would also look better than the cut-off default text.

@j-grosse j-grosse added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Dec 12, 2023
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@ChinmayMhatre
Copy link
Member

Thanks for raising the issue, This is happening because the user doesn't exist on GitHub.
image
@eddiejaoude

@eddiejaoude
Copy link
Member

I see the problem

LIGHT MODE

Screenshot 2023-12-17 at 21 13 19

DARK MODE

Screenshot 2023-12-17 at 21 13 23

@EddieHubCommunity EddieHubCommunity unlocked this conversation Dec 18, 2023
@ankittankal
Copy link
Contributor

Hey @eddiejaoude, I would like to work on this issue.

@anirudh-hegde
Copy link

Hey, @j-grosse
I viewed your profile, no issues about your profile picture.
Your profile picture appears on https://www.biodrop.io/LinuxGamer however disappears on https://www.biodrop.io/EddieHubCommunity?tab=testimonials.

So, just try changing your profile picture and check whether the issue exists

@j-grosse
Copy link
Author

Hey, @j-grosse I viewed your profile, no issues about your profile picture. Your profile picture appears on https://www.biodrop.io/LinuxGamer however disappears on https://www.biodrop.io/EddieHubCommunity?tab=testimonials.

So, just try changing your profile picture and check whether the issue exists

Thanks, but it‘s not my profile. If the user has no profile picture on Github an automatically added default placeholder profile image would be the solution. But here the user does not even exist on Github anymore. So there was a picture from the user. Maybe just a very seldom case. Maybe close the issue @eddiejaoude ?

@SaraJaoude
Copy link
Member

Thank you @j-grosse

It might be that they changed their username. However I do agree and this issue should be closed, which I will do now.

@SaraJaoude SaraJaoude closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2023
@j-grosse j-grosse changed the title [BUG] default profile image text is not visible in dark mode [BUG] Default profile image text should be visible in dark mode Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 goal: fix undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 💬 talk: discussion undefined
Projects
None yet
Development

No branches or pull requests

6 participants